[HOLD for payment 2024-11-14] [$250] Bank account - Website in upper-case letters is accepted despite validation error

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.58-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh2610001@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Workflows.
3. Click Connect bank account.
4. Click Connect manually.
5. Proceed to "What's your company’s website?".
6. Enter an invalid website to trigger the error.
7. Note that the error mentions "Please enter a valid website using lower-case letters.".
8. Enter a website using upper-case letters.
9. Click Next.

Expected Result:

App will not proceed to the next page because the error mentions that the website must be in lower-case letters (production behavior).

Actual Result:

App proceeds to the next page when using upper-case letters despite the error.

The error message should be updated if this is the expected behavior.

The same validation message also happens in Invoice company website page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6656059_1730858126541.20241106_095110.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854108988948033314
• Upwork Job ID: 1854108988948033314
• Last Price Increase: 2024-11-06
• Automatic offers:
• suneox | Reviewer | 104768561
• ahmedGaber93 | Contributor | 104768562

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NJ-2020]

Offending PR: #51545

We convert the url to lowercase when checking inside the validation function

App/src/pages/ReimbursementAccount/BusinessInfo/substeps/WebsiteBusiness.tsx

Line 37 in 573162f

if (values.website && !ValidationUtils.isValidWebsite(Str.sanitizeURL(values.website, CONST.COMPANY_WEBSITE_DEFAULT_SCHEME))) {

it should be:

if (values.website && !ValidationUtils.isValidWebsite(values.website)) {