[HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] Invoices - Company website field does not show the website when it is auto populated

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.58-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+sjdosjdsod@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with Expensifail account.
3. Create a new workspace.
4. Go to workspace settings > More features.
5. Enable Invoices.
6. Go to Invoices.
7. Click Company website.

Expected Result:

Company website field should show the website because the company website is auto populated in Step 7.

Actual Result:

Company website field does not show the website when the company website is auto populated in Step 7.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6656034_1730856285708.20241106_092129.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NJ-2020]

Offending PR: #51545

Inside the company website detail page we use defaultWebsiteExample if the current policy website is undefined

App/src/pages/workspace/invoices/WorkspaceInvoicingDetailsWebsite.tsx

Line 37 in 573162f

const defaultWebsiteExample = useMemo(() => getDefaultCompanyWebsite(session, user), [session, user]);

App/src/pages/workspace/invoices/WorkspaceInvoicingDetailsWebsite.tsx

Line 94 in 573162f

defaultValue={policy?.invoice?.companyWebsite ?? defaultWebsiteExample}

So when the current policy website is undefined we will use the defaultWebsiteExample and return the url with the private domain

App/src/libs/BankAccountUtils.ts

Lines 5 to 7 in 573162f

	function getDefaultCompanyWebsite(session: OnyxEntry<OnyxTypes.Session>, user: OnyxEntry<OnyxTypes.User>): string {
	return user?.isFromPublicDomain ? '' : `https://www.${Str.extractEmailDomain(session?.email ?? '')}`;
	}

But when displaying the website title inside the menu items we don't use defaultWebsiteExample if the policy website is undefined

App/src/pages/workspace/invoices/WorkspaceInvoicingDetailsSection.tsx

Line 46 in 573162f

title={policy?.invoice?.companyWebsite}

We should use the same way as we do inside the workspace website detail page

const [session] = useOnyx(ONYXKEYS.SESSION);
const [user] = useOnyx(ONYXKEYS.USER);
const defaultWebsiteExample = useMemo(() => getDefaultCompanyWebsite(session, user), [session, user]);
<MenuItemWithTopDescription
    key={translate('workspace.invoices.companyWebsite')}
    shouldShowRightIcon
    title={policy?.invoice?.companyWebsite ?? defaultWebsiteExample}
    description={translate('workspace.invoices.companyWebsite')}
    onPress={() => Navigation.navigate(ROUTES.WORKSPACE_INVOICES_COMPANY_WEBSITE.getRoute(policyID))}
    style={horizontalPadding}
/>