Public room - Tour link appears for anonymous user in public room

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.58-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+sjdosjdsod@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log out if logged in.
3. Navigate to public room link anonymously.
4. Open FAB.

Expected Result:

Tour link will not appear for anonymous user.

Actual Result:

Tour link appears for anonymous user in public room.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6656088_1730861803145.20241106_105351.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Public room - Tour link appears for anonymous user in public room### What is the root cause of that problem?

What is the root cause of that problem?

Offending PR: #51136

We did not check here if the user is anonymous

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Lines 441 to 445 in 7b9a0cd

	...(!hasSeenTour
	? [
	{
	icon: Expensicons.Binoculars,
	iconStyles: styles.popoverIconCircle,

What changes do you think we should make in order to solve the problem?

We should check here if the user anonymous

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Lines 441 to 445 in 7b9a0cd

	...(!hasSeenTour
	? [
	{
	icon: Expensicons.Binoculars,
	iconStyles: styles.popoverIconCircle,

Or we can prevent of opening the url if the user is anonymous

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Lines 449 to 451 in 7b9a0cd

	onSelected: () => {
	Welcome.setSelfTourViewed();
	Link.openExternalLink(navatticURL);

onSelected: () => {
    if(Session.isAnonymousUser()) {
      return;
    }
    Welcome.setSelfTourViewed();
    Link.openExternalLink(navatticURL);
},

What alternative solutions did you explore? (Optional)