[HOLD for payment 2024-12-05] [$250] Expense - Expense preview shows "x paid amount" when expense payment is cancelled offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.58-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh2610010@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workflows are enabled and Add approvals feature is enabled

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit an expense, approve it and pay elsewhere
4. Go offline
5. Click on the expense preview
6. Click on the report header
7. Click Cancel payment
8. Cancel the payment
9. Click Unapprove
10. Click on the report subtitle to return to the main chat

Expected Result:

The expense preview will show "x owes amount" without checkmark because the expense payment is cancelled offline

Actual Result:

The expense preview shows "x paid amount" when expense payment is cancelled offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6656772_1730912697949.20241107_010050.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854562907265274025
• Upwork Job ID: 1854562907265274025
• Last Price Increase: 2024-11-07
• Automatic offers:
• mkzie2 | Contributor | 104908738

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-11-12 14:23:20 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expense preview shows "x paid amount" when expense payment is cancelled offline

What is the root cause of that problem?

iouSettled condition is true if isSettled function returns true or action.childStatusNum is CONST.REPORT.STATUS_NUM.REIMBURSED

App/src/components/ReportActionItem/ReportPreview.tsx

Line 135 in c755314

const iouSettled = ReportUtils.isSettled(iouReportID) || action?.childStatusNum === CONST.REPORT.STATUS_NUM.REIMBURSED;

After paying the expense, action.childStatusNum is updated correctly. But when we cancel the payment and unapproved the report, this status isn't updated (only the statusNum of the expense report is updated).

It leads iouSettled is still true because this condition action?.childStatusNum === CONST.REPORT.STATUS_NUM.REIMBURSED is still true

App/src/components/ReportActionItem/ReportPreview.tsx

Line 135 in c755314

const iouSettled = ReportUtils.isSettled(iouReportID) || action?.childStatusNum === CONST.REPORT.STATUS_NUM.REIMBURSED;

And the preview is displayed x paid amount

What changes do you think we should make in order to solve the problem?

We should only check action?.childStatusNum when the iou report data isn't available

const iouSettled = iouReport ? ReportUtils.isSettled(iouReportID) : action?.childStatusNum === CONST.REPORT.STATUS_NUM.REIMBURSED;

App/src/components/ReportActionItem/ReportPreview.tsx

Line 135 in c755314

const iouSettled = ReportUtils.isSettled(iouReportID) || action?.childStatusNum === CONST.REPORT.STATUS_NUM.REIMBURSED;

What alternative solutions did you explore? (Optional)

When we cancel the payment and unapproved the report we should update childStateNum and childStatusNum of the parent report action in optimistic data and reset it in failure data with the value like here and here

The value of childStateNum and childStatusNum will be the same as stateNum and statusNum values that we updated for the expense report. Here is an example

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${expenseReport.parentReportID}`,
    value: {
        [expenseReport.parentReportActionID]: {
            childStateNum: stateNum,
            childStatusNum: statusNum,
        },
    },
},

App/src/libs/actions/IOU.ts

Lines 7551 to 7552 in c755314

	const stateNum: ValueOf<typeof CONST.REPORT.STATE_NUM> = approvalMode === CONST.POLICY.APPROVAL_MODE.OPTIONAL ? CONST.REPORT.STATE_NUM.SUBMITTED : CONST.REPORT.STATE_NUM.APPROVED;
	const statusNum: ValueOf<typeof CONST.REPORT.STATUS_NUM> = approvalMode === CONST.POLICY.APPROVAL_MODE.OPTIONAL ? CONST.REPORT.STATUS_NUM.CLOSED : CONST.REPORT.STATUS_NUM.APPROVED;

App/src/libs/actions/IOU.ts

Lines 7351 to 7352 in c755314

	stateNum: CONST.REPORT.STATE_NUM.SUBMITTED,
	statusNum: CONST.REPORT.STATUS_NUM.SUBMITTED,

[joekaufmanexpensify]

Reproduced. Yeah, if we're showing Approve again on the report preview if you unapproved while offline, it seems odd that we are showing the report as paid when it was also canceled offline.

Seems like this is a pattern B situation based on the unapproved and payment cancel comments having .5 opacity. Not sure if we need to do something to signal on the report preview to signal pattern B too though.

2024-11-07_11-31-17.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021854562907265274025

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

@sobitneupane, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!