[HOLD][$250] Search - Suggestion still shows the report when it is already selected as search query

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+khcategory18@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Open any report.
3. Open search router.
4. Enter in: followed by report name.
5. Select the report from the suggestion.

Expected Result:

The suggestion will not show the selected report because the report is already selected (production behavior).

Actual Result:

The suggestion shows the selected report when the report is already selected.
This issue only happens with in: search query and does not happen with from, to, category, tag etc

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6657948_1731003896136.20241108_022133.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854651066569405634
• Upwork Job ID: 1854651066569405634
• Last Price Increase: 2024-11-14

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-11-07 20:07:36 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The suggestion shows the selected report when the report is already selected.
This issue only happens with in: search query and does not happen with from, to, category, tag etc

What is the root cause of that problem?

We are missing the filter in type in with alreadyAutocompletedKeys value similar to what we did with other types

App/src/components/Search/SearchRouter/SearchRouter.tsx

Lines 251 to 254 in e3e4e53

	const filteredChats = searchOptions.recentReports
	.filter((chat) => chat.text?.toLowerCase()?.includes(autocompleteValue.toLowerCase()))
	.sort((chatA, chatB) => (chatA > chatB ? 1 : -1))
	.slice(0, 10);

What changes do you think we should make in order to solve the problem?

We should add condition with alreadyAutocompletedKeys value in filter function here

const filteredChats = searchOptions.recentReports
      .filter((chat) => chat.text?.toLowerCase()?.includes(autocompleteValue.toLowerCase()) && !alreadyAutocompletedKeys.includes(chat.text?.toLowerCase()))
      .sort((chatA, chatB) => (chatA > chatB ? 1 : -1))
      .slice(0, 10);

We can find any missing types and do the same.

What alternative solutions did you explore? (Optional)

NA

[MarioExpensify]

I was able to reproduce here, but hardly a deploy blocker. Let's make this External and move forward with the deploy.