[HOLD for payment 2024-11-29] [$150] Switch to classic in the same tab

[anmurali]

Problem: When a user switches to classic, we open www.expensify.com in a new tab. It isn't intuitive to them to close that tab on web. As a result they switch over and over again.

Solution: When a user switches to Classic, open www.expensify.com in the same tab, rather than a new tab

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854652609104860244
• Upwork Job ID: 1854652609104860244
• Last Price Increase: 2024-11-07
• Automatic offers:
• allgandalf | Reviewer | 104852713

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021854652609104860244

[melvin-bot]

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

[truph01]

Edited by proposal-police: This proposal was edited at 2024-11-08 08:54:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Switch to classic in the same tab

What is the root cause of that problem?

• In:

App/src/libs/asyncOpenURL/index.website.ts

Line 19 in 7f55e03

Linking.openURL(typeof url === 'string' ? url : url(params));

we always call Linking.openURL which will open a new tab.

What changes do you think we should make in order to solve the problem?

• In:
  

  App/src/libs/asyncOpenURL/index.website.ts

  Line 9 in 7f55e03

  const asyncOpenURL: AsyncOpenURL = (promise, url, shouldSkipCustomSafariLogic) => {

  
  we should introduce new param shouldOpenInSameTab:

const asyncOpenURL: AsyncOpenURL = (promise, url, shouldSkipCustomSafariLogic, shouldOpenInSameTab = false) => {

and use it in:

App/src/libs/asyncOpenURL/index.website.ts

Line 19 in 7f55e03

Linking.openURL(typeof url === 'string' ? url : url(params));

                if (shouldOpenInSameTab) {
                    window.location.href = typeof url === 'string' ? url : url(params);
                    return;
                }
                Linking.openURL(typeof url === 'string' ? url : url(params));

• Then we should update:

App/src/libs/actions/Link.ts

Line 72 in 7f55e03

function openOldDotLink(url: string) {

function openOldDotLink(url: string, shouldOpenInSameTab = false) {

and

App/src/libs/actions/Link.ts

Line 84 in 7f55e03

(oldDotURL) => oldDotURL,

        (oldDotURL) => oldDotURL, undefined, shouldOpenInSameTab

• Finally, update:

App/src/pages/settings/ExitSurvey/ExitSurveyConfirmPage.tsx

Line 86 in 7f55e03

Link.openOldDotLink(CONST.OLDDOT_URLS.INBOX);

                        Link.openOldDotLink(CONST.OLDDOT_URLS.INBOX, true);

What alternative solutions did you explore? (Optional)

[anmurali]

@allgandalf this is a critical issue as we have a lot of confused users, so appreciate you picking a proposal from above as soon as possible!