[HOLD for payment 2024-11-28] [$250] Onboarding task - `Take me to...` link contains -1 instead of WS ID and opens not here page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.59.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5195696
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/ and log in with a new account
2. Select "Get paid back from my employer" and enter a name
3. Click on FAB > Submit expense
4. Submit a manual expense to a new user
5. Log out and log in as the other user
6. Navigate to the 1:1 chat with the expense submitter
7. Click on Pay with Expensify > Business bank account
8. Close the Connect bank account RHP
9. Navigate to Concierge
10. Open an onboarding task with a link to WS settings, e.g. "Set up categories"
11. Click on the link "Take me to..."

Expected Result:

The link contains the Workspace ID, and user is navigated to the corresponding workspace settings

Actual Result:

The link contains -1 instead of the Workspace ID, and user is navigated to the "Not here" page

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6658459_1731044390554.Recording__925.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021856146440240693847
• Upwork Job ID: 1856146440240693847
• Last Price Increase: 2024-11-12
• Automatic offers:
• mkzie2 | Contributor | 104903064

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The link contains -1 instead of the Workspace ID, and user is navigated to the "Not here" page

What is the root cause of that problem?

When we select Bussiness bank account, we complete onboarding here with onboardingPurpose as CONST.ONBOARDING_CHOICES.MANAGE_TEAM

App/src/components/AddPaymentMethodMenu.tsx

Line 120 in c658375

completePaymentOnboarding(CONST.PAYMENT_SELECTED.BBA);

App/src/libs/actions/IOU.ts

Lines 7676 to 7679 in c658375

	if (introSelected.inviteType === CONST.ONBOARDING_INVITE_TYPES.IOU && paymentSelected === CONST.IOU.PAYMENT_SELECTED.BBA) {
	onboardingPurpose = CONST.ONBOARDING_CHOICES.MANAGE_TEAM;
	}

Then we call completeOnboarding without onboardingPolicyID which causes the setting tag/category to have the WS link with ID -1

App/src/libs/actions/IOU.ts

Line 7684 in c658375

Report.completeOnboarding(onboardingPurpose, CONST.ONBOARDING_MESSAGES[onboardingPurpose], personalDetails?.firstName ?? '', personalDetails?.lastName ?? '', paymentSelected);

What changes do you think we should make in order to solve the problem?

We can add a new prop in AddPaymentMethodMenu shouldCallCompletePaymentOnboarding with the default value as true and only call completePaymentOnboarding in this component if shouldCallCompletePaymentOnboarding is true

After that, we can pass shouldCallCompletePaymentOnboarding={false} here

And we will call completePaymentOnboarding in each case of selectPaymentMethod function and pass onboardingPolicyID to completePaymentOnboarding function if we create a new policy.

App/src/components/KYCWall/BaseKYCWall.tsx

Line 101 in 17cae11

const selectPaymentMethod = useCallback(

App/src/components/KYCWall/BaseKYCWall.tsx

Line 111 in 17cae11

const {policyID, workspaceChatReportID, reportPreviewReportActionID} = Policy.createWorkspaceFromIOUPayment(iouReport) ?? {};

What alternative solutions did you explore? (Optional)

In this function here, we can check if we don't have any policy that we're owner, we will call Policy.createWorkspace function and get the policyID, adminReportID to pass to completeOnboarding here

App/src/libs/actions/IOU.ts

Lines 7676 to 7679 in c658375

	if (introSelected.inviteType === CONST.ONBOARDING_INVITE_TYPES.IOU && paymentSelected === CONST.IOU.PAYMENT_SELECTED.BBA) {
	onboardingPurpose = CONST.ONBOARDING_CHOICES.MANAGE_TEAM;
	}

[melvin-bot]

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

@deetergp @blazejkustra this is a bug with the Guided Setup: Stage 3. Do you agree with the approach here?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021856146440240693847