[HOLD for payment 2024-11-29] [$250] Track expense - Options are still present in thread details after the expense is deleted

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.63-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+29302390@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to self DM
3. Track an expense
4. Go to transaction thread
5. Send a message
6. Click on the report header
7. Click Delete expense
8. Delete the expense
9. Click on the thread in the main chat to return to the thread
10. Click report header

Expected Result:

Track expense options should not be displayed in thread after the expense is deleted

Actual Result:

Track expense options is still displayed in thread after the expense is deleted.
The options lead to not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6666489_1731686292257.20241115_235512.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021858671461676585752
• Upwork Job ID: 1858671461676585752
• Last Price Increase: 2024-11-19
• Automatic offers:
• ikevin127 | Reviewer | 104973306
• twilight2294 | Contributor | 104973308

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Options are still present in thread details after the expense is deleted

What is the root cause of that problem?

We do not check if !isDeletedParentAction hence it is shown even when it is deleted

App/src/pages/ReportDetailsPage.tsx

Line 378 in 88713ab

if (isTrackExpenseReport) {

What changes do you think we should make in order to solve the problem?

Add isTrackExpenseReport && !isDeletedParentAction check to fix this

What alternative solutions did you explore? (Optional)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track expense - Options are still present in thread details after the expense is deleted

What is the root cause of that problem?

The track expense option is displayed if a report is a track expense report.

App/src/pages/ReportDetailsPage.tsx

Line 378 in 88713ab

if (isTrackExpenseReport) {

isTrackExpenseReport is true if the parent report action is track expense action and the parent report is the selfDM.

App/src/libs/ReportUtils.ts

Line 1651 in 88713ab

return !isEmptyObject(parentReportAction) && selfDMReportID === report.parentReportID && ReportActionsUtils.isTrackExpenseAction(parentReportAction);

After we delete a track expense, the parent report action still has type as track in originalMessage then the track expense option still appears in the report detail page

What changes do you think we should make in order to solve the problem?

Return false in isTrackExpenseReport function if the parent report action is deleted action

return (
    !isEmptyObject(parentReportAction) &&
    selfDMReportID === report.parentReportID &&
    ReportActionsUtils.isTrackExpenseAction(parentReportAction) &&
    !ReportActionsUtils.isDeletedAction(parentReportAction)
);

App/src/libs/ReportUtils.ts

Line 1651 in 88713ab

return !isEmptyObject(parentReportAction) && selfDMReportID === report.parentReportID && ReportActionsUtils.isTrackExpenseAction(parentReportAction);

Or we can do this in isTrackExpenseAction function

What alternative solutions did you explore? (Optional)

Or after we delete the track expense, we should remove the type in originalMessage of parent report action or change type to the according type.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021858671461676585752

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[alexpensify]

@ikevin127 when you get a chance, please review these proposals and identify whether one will fix the issue. Thank you!