[HOLD for payment 2024-12-05] [$125] Xero - Selected Xero bank account is not highlighted with a green checkmark

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.63-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5220818
Email or phone of affected tester (no customers): https://expensify.testrail.io/index.php?/tests/view/5220818
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Accounting.
3. Connect to Xero.
4. After connecting to Xero, click Export.
5. Click Xero bank account.

Expected Result:

The selected Xero bank account should be highlighted with a green checkmark.

Actual Result:

The selected Xero bank account is not highlighted with a green checkmark.
It is only highlighted after manually selecting it.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6668343_1731931675725.bandicam_2024-11-18_20-03-24-662.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021858554918265952310
• Upwork Job ID: 1858554918265952310
• Last Price Increase: 2024-11-18
• Automatic offers:
• ahmedGaber93 | Reviewer | 105021706
• twilight2294 | Contributor | 105021707

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-11-18 12:44:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Xero - Selected Xero bank account is not highlighted with a green checkmark

What is the root cause of that problem?

We are setting the selected bank account to bankAccounts?.[0] as a backup when there is no bank account in policy?.connections?.xero?.data.bankAccounts that matches with exportConfiguration?.nonReimbursableAccount

App/src/pages/workspace/accounting/xero/export/XeroExportConfigurationPage.tsx

Line 26 in 63c8dd2

return selectedAccount?.name ?? bankAccounts?.[0]?.name ?? '';

but we didn't give the same backup in the account select page here

App/src/pages/workspace/accounting/xero/export/XeroBankAccountSelectPage.tsx

Line 31 in 63c8dd2

() => getXeroBankAccounts(policy ?? undefined, config?.export?.nonReimbursableAccount),

What changes do you think we should make in order to solve the problem?

We should give the same fallback value in.XeroBankAccountSelectPage.tsx, i.e.

    const {bankAccounts} = policy?.connections?.xero?.data ?? {};

    const xeroSelectorOptions = useMemo<SelectorType[]>(
        () => getXeroBankAccounts(policy ?? undefined, config?.export?.nonReimbursableAccount ?? bankAccounts?.[0]?.id),
        [config?.export?.nonReimbursableAccount, policy, bankAccounts],

What alternative solutions did you explore? (Optional)

[sakluger]

This one feels like a super easy change so I'm going to set the price to $125. If there are additional fields where this is happening, or if it is actually more complex than I realize, let me know and we can consider increasing the price.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021858554918265952310

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[melvin-bot]

Upwork job price has been updated to $125