[HOLD for payment 2024-12-17] [$250] unstable sound levels after unmuting the video

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.64-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @sumo-slonik
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

1. Upload or send a video file as attachment
2. Play the video
3. Mute and unmute the volume

Expected Result:

The volume level is stable

Actual Result:

The volume level is unstable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-11-20.at.16.24.43.mov

volume.unstable.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021862136266763412710
• Upwork Job ID: 1862136266763412710
• Last Price Increase: 2024-11-28

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unstable state of the video sound level.

What is the root cause of that problem?

When we press the sound to unmute, we update the volume to 1 and set the isMuted to false.

App/src/components/VideoPlayerContexts/VolumeContext.tsx

Lines 13 to 20 in c18812a

	const updateVolume = useCallback(
	(newVolume: number) => {
	if (!currentVideoPlayerRef.current) {
	return;
	}
	currentVideoPlayerRef.current.setStatusAsync({volume: newVolume, isMuted: newVolume === 0});
	// eslint-disable-next-line react-compiler/react-compiler
	volume.value = newVolume;

But in BaseVideoPlayer, inside the playback status update listener, we update the volume to 0.25 if the volume is previously 0 and it's previously muted.

App/src/components/VideoPlayer/BaseVideoPlayer.tsx

Lines 214 to 219 in c18812a

	if (prevIsMutedRef.current && prevVolumeRef.current === 0 && !status.isMuted) {
	updateVolume(0.25);
	}
	if (isFullScreenRef.current && prevVolumeRef.current !== 0 && status.volume === 0 && !status.isMuted) {
	currentVideoPlayerRef.current?.setStatusAsync({isMuted: true});
	}

That logic was added in #45277. The root cause is explained on the selected proposal, but basically, when in fullscreen mode, pressing the sound to unmute it will do nothing. It's because the button changes the isMuted to false, but the volume is still 0. So, the above logic was added to change the volume to 0.25 (not sure why 0.25 and not 1).

What changes do you think we should make in order to solve the problem?

We need to apply that logic only if we are on fullscreen mode. We already did that for the 2nd if above.

if (isFullScreenRef.current) {
    if (prevIsMutedRef.current && prevVolumeRef.current === 0 && !status.isMuted) {
        updateVolume(0.25);
    }
    if (prevVolumeRef.current !== 0 && status.volume === 0 && !status.isMuted) {
        currentVideoPlayerRef.current?.setStatusAsync({isMuted: true});
    }
}

[blazejkustra]

@bernhardoj This issue doesn't have help wanted tag yet, so no proposal needed.

@sumo-slonik reported this issue and we believe having hardcoded 0.25 value is very unusual. Rather than adding more logic we would like to simplify this so it is less prone to bugs in a long run.

[blazejkustra]

We found this bug while investigating Reanimated usage in the app (we are both from Software Mansion). @zanyrenney if you agree that we want to fix this bug and the issue gets 'Help Wanted', please consider assigning @sumo-slonik 😄

[sumo-slonik]

Hey! I'm Kuba Nowakowski from Software Mansion, an expert agency, and I'd like to work on this issue!

[zanyrenney]

Hey team! I can't hear volume in the video attached above. Should there be? @blazejkustra @sumo-slonik ?

[sumo-slonik]

HI @zanyrenney.
In the video I posted here you can see the unstable sound on the animation of the sound icon, unfortunately it is only a recorded screen.

[zanyrenney]

@sumo-slonik there is no link to the "here" - please can you share it?

[blazejkustra]

Kuba is referring to the first video from the description (look at the volume icon that is changing unexpectedly) @zanyrenney

Screen.Recording.2024-11-25.at.14.36.14.mov