[HOLD for payment 2024-12-03] [HOLD for payment 2024-11-29] Search - Website crashes after exploring expenses in search for some time

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.65-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

1. Open the staging.new.expensify.com website.
2. Log in with an account with several expenses on it.
3. Tap on search on the bottom of the page.
4. Open any expense.
5. Tap on the arrow on the top left corner.
6. Open a different expense.
7. Tap on the arrow on the top left corner.
8. Repeat steps 4 - 5 a few more times.
9. Verify that the user can continue exploring all the expenses without the website crashing.

Expected Result:

The user should be able to explore expenses in search without the website crashing.

Actual Result:

The website crashes after opening and closing expenses for some time in search section.
Error Message - "Uh oh, something went wrong."

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6671401_1732156471509.Crash_Search.1.mp4

2111_1.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The website crashes after opening and closing expenses for some time in search section.
Error Message - "Uh oh, something went wrong."

What is the root cause of that problem?

We pass the reportID as report?.reportID, which can be empty string here

App/src/pages/home/ReportScreen.tsx

Line 172 in 376f9f0

reportID: reportOnyx.reportID ?? '',

App/src/pages/home/ReportScreen.tsx

Line 224 in 376f9f0

const {reportActions, linkedAction, sortedAllReportActions, hasNewerActions, hasOlderActions} = usePaginatedReportActions(reportID, reportActionIDFromRoute);

Then the app crashes when we use useOnyx here, the key changes from report_id to report_

App/src/hooks/usePaginatedReportActions.ts

Line 15 in 376f9f0

const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`);

What changes do you think we should make in order to solve the problem?

Fallback reportID to -1 here

App/src/pages/home/ReportScreen.tsx

Line 172 in 376f9f0

reportID: reportOnyx.reportID ?? '',

Or we can use reportIDFromRoute instead

App/src/pages/home/ReportScreen.tsx

Line 224 in 376f9f0

const {reportActions, linkedAction, sortedAllReportActions, hasNewerActions, hasOlderActions} = usePaginatedReportActions(reportID, reportActionIDFromRoute);

Or we can add fallback -1 here

 const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID || '-1'}`); 

App/src/hooks/usePaginatedReportActions.ts

Line 15 in 376f9f0

const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`);

What alternative solutions did you explore? (Optional)

[mkzie2]

@MonilBhavsar I can raise a quick fix if needed.