[$250] Chat - Specific "not found page" link crashes the app

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.65-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a new account
3. Send this link in composer after onboarding flow: www.staging.new.expensify.com/r/6272828282

Expected Result:

User expects to get a page not found message

Actual Result:

The first time around, the app crashes, after reloading from crash, it displays the correct page not found

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6671482_1732163542551.App_crashes_with_specific_link.mp4

2111.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sobitneupane

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021861021052919519904
• Upwork Job ID: 1861021052919519904
• Last Price Increase: 2024-12-02

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The first time around, the app crashes, after reloading from crash, it displays the correct page not found

What is the root cause of that problem?

We have Onyx error when changing key from undefined to ''

What changes do you think we should make in order to solve the problem?

We should fallback as '-1' here

  reportID: reportOnyx.reportID ?? '-1',

App/src/pages/home/ReportScreen.tsx

Line 172 in 376f9f0

reportID: reportOnyx.reportID ?? '',

What alternative solutions did you explore? (Optional)

[adelekennedy]

I don't think this is a deploy blocker - keeping it hourly in case @nkuoch you disagree, preemptively adding external label in case