[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] [$250] [CRITICAL] Multiple workspaces get created when someone either refreshes the page, or drops off and returns later.

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.65-1
Reproducible in staging?: Y
**Reproducible in production?:**Y
**If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:**N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation : #convert thread

Action Performed:

1. Sign-up on expensify.com
2. Choose the “1-9” option on the home page (signUpQualifier: vsb)
3. Get redirected to new.expensify.com
4. Observe a workspace is created
5. Don’t complete the onboarding modal steps (hasCompletedGuidedSetupFlow: false)
6. Refresh the page
7. Observe another workspace is created
8. Type in expensify.com in the browser URL and click enter
9. Get redirected to new.expensify.com (classicRedirect.dismissed: false)
10. Another workspace is created

Expected Result:

If we’ve created a workspace for the new sign-up already, don’t create another one when they refresh or return.

Actual Result:

We create a workspace every time they refresh or get redirected to NewDot and haven’t completed the onboarding modal steps yet.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Refreshing the page

2024-11-21_12-29-41.mp4

Returning to expensify.com

2024-11-21_12-08-53.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021859580489556912069
• Upwork Job ID: 1859580489556912069
• Last Price Increase: 2024-11-21
• Automatic offers:
• ishpaul777 | Contributor | 105120851

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[mountiny]

@nkdengineer This is coming from your PR here https://github.com/Expensify/App/pull/51839/files

We should not be creating the workspace on each mount forever. Only if there is no group policy the user is admin of yet

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Multiple workspaces get created when someone either refreshes the page, or drops off and returns later.

What is the root cause of that problem?

We are already returning early in case there is onboarding policy id set but on refresh the useOnyx will not make the data available and the effect runs too early

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Lines 61 to 62 in 2d2555b

	if (!isVsb || !!onboardingPolicyID) {
	return;

What changes do you think we should make in order to solve the problem?

We should first check that onBoarding Policy ID data is loaded not loading

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Line 48 in 2d2555b

const [onboardingPolicyID] = useOnyx(ONYXKEYS.ONBOARDING_POLICY_ID);

    const [onboardingPolicyID, onboardingPolicyIDResults] = useOnyx(ONYXKEYS.ONBOARDING_POLICY_ID);

if (!isVsb || !!onboardingPolicyID || isLoadingOnyxValue(onboardingPolicyIDResults)) {
            return;
        }

What alternative solutions did you explore? (Optional)

[FitseTLT]

@mountiny The code is already doing that but the effect runs too early for the useEffect. I have posted a fix I can immediately raise a PR if you want 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021859580489556912069