[$250] Track expense-In self DM, create expense is shown instead track expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.65-1
Reproducible in staging?: Y
Reproducible in production?: Y
Isuue was found when executing this PR: #52786
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Login with new gmail account
3. Open self DM
4. Tap plus icon next to chat input

Expected Result:

In self DM, track expense must be shown .

Actual Result:

In self DM, create expense is shown instead track expense.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6671460_1732161962885.Screenrecorder-2024-11-21-09-31-54-5.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021861530490609565618
• Upwork Job ID: 1861530490609565618
• Last Price Increase: 2024-12-10

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-11-21 13:15:52 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In self DM, create expense is shown instead track expense.

What is the root cause of that problem?

We display Create expense if canUseCombinedTrackSubmit is true.

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 162 to 163 in 4617816

	icon: canUseCombinedTrackSubmit ? getIconForAction(CONST.IOU.TYPE.CREATE) : getIconForAction(CONST.IOU.TYPE.TRACK),
	text: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

What changes do you think we should make in order to solve the problem?

I think we should display Track expense for all case in the plus icon of SelfDM

icon:  getIconForAction(CONST.IOU.TYPE.TRACK),
text: translate('iou.trackExpense'),

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 162 to 163 in 4617816

	icon: canUseCombinedTrackSubmit ? getIconForAction(CONST.IOU.TYPE.CREATE) : getIconForAction(CONST.IOU.TYPE.TRACK),
	text: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

OPTIONAL: We can also change this to always display Track expense

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 58 in 4617816

[CONST.IOU.TYPE.TRACK]: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

confirmed in slack that it should be track

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021861530490609565618

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)