[HOLD for payment 2024-12-16] Search - No sound when paying expense in Search

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+29302390@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense to the workspace.
4. Click dropdown button on the expense preview.
5. Select Pay elsewhere (do not pay it).
6. Go to Search.
7. Click Pay button.

Expected Result:

There will be sound when paying expense in Search.

Actual Result:

There is no sound when paying expense in Search.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6674090_1732364031401.20241123_201226.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - No sound when paying expense in Search

What is the root cause of that problem?

When clicking the action button on the report preview or the button in the header, we are using the playSound function to play the sound

App/src/components/SettlementButton/index.tsx

Line 217 in 3ebe852

playSound(SOUNDS.SUCCESS);

What changes do you think we should make in order to solve the problem?

We should apply the same approach to actions executed on the Search Page. The playSound function can be incorporated either after the payMoneyRequestOnSearch function. Or we can add playSound function into payMoneyRequestOnSearch.

App/src/libs/actions/Search.ts

Lines 90 to 98 in 3ebe852

	if (lastPolicyPaymentMethod === CONST.IOU.PAYMENT_TYPE.ELSEWHERE) {
	payMoneyRequestOnSearch(hash, [{reportID: item.reportID, amount, paymentType: lastPolicyPaymentMethod}], transactionID);
	return;
	}
	const hasVBBA = !!allSnapshots?.[`${ONYXKEYS.COLLECTION.SNAPSHOT}${hash}`]?.data?.[`${ONYXKEYS.COLLECTION.POLICY}${item.policyID}`]?.achAccount?.bankAccountID;
	if (hasVBBA) {
	payMoneyRequestOnSearch(hash, [{reportID: item.reportID, amount, paymentType: lastPolicyPaymentMethod}], transactionID);
	return;

What alternative solutions did you explore? (Optional)

[ishpaul777]

offending PR #52441