[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] [$500] Web - Expense - Submit button on confirmation page has extra bottom margin

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.67-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+232803@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Go to + > Submit expense > Next.
4. Enter amount > Next.

Expected Result:

Submit button will not have extra bottom margin (production behavior).

Actual Result:

Submit button has extra bottom margin.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6677289_1732647525932.20241127_024755.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Edited by proposal-police: This proposal was edited at 2024-11-26 19:15:53 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit button has extra bottom margin.

What is the root cause of that problem?

Offending PR: #52392

We have extra styles.mb6 here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 609 in 967cc5c

<View style={[styles.flex1, styles.mb6]}>

What changes do you think we should make in order to solve the problem?

We should remove styles.mb6 in this style

What alternative solutions did you explore? (Optional)

Or we can revert to use safeAreaPaddingBottomStyle from ScreenWrapper

[mountiny]

cc @kirillzyusko