[$250] [HOLD for payment 2024-12-11] Android - Expense - Save button moves up and down when keyboard is open

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
**Email or phone of affected tester (no customers):**applausetester+232803@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch ND or hybrid app.
2. Go to workspace chat.
3. Tap + > Submit expense > Manual.
4. Enter amount > Next.
5. Tap Merchant.
6. Might have to exit merchant editor and tap Merchant field again to see Save button move when keyboard is open.

Expected Result:

Save button will not move up and down when the keyboard is open.

Actual Result:

Save button moves up and down when the keyboard is open.

Similar behavior is seen across the app when keyboard is open and where there is Save or Submit button.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6677463_1732657689882.Screen_Recording_20241127_054453.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021865866933542877637
• Upwork Job ID: 1865866933542877637
• Last Price Increase: 2024-12-08

Issue Owner

Current Issue Owner: @jliexpensify

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kirillzyusko]

I already mentioned this problem here - #42143 (comment)

This is PR that introduced new hook useSafePaddingBottomStyle hook, that updates style from JS thread. However new implementation of KeyboardAvoidingView is based on reanimated usage (i. e. synchronous style changes depending on keyboard position), but this hook performs updates in JS (which are slower) and because of that we see this two stage update on Android.

We can fix it:

• by making useSafePaddingBottomStyle returning an instance of useAnimatedStyle;
• or by specifying necessary margin pb5 as keyboardVerticalOffset property in KeyboardAvoidingView (this approach is preferable, because we don't need to create many animated views and a single view will control keyboard interpolation).

However it's pretty big changes in both variants and it will take some time to implement (because useSafePaddingBottomStyle implicitly gets used in many places already, so we will have to go through each screen and verify that there is no jumps).

@mountiny do you think we can deprioritise this and remove blocker label? It was kind of something expected to see such instant button shifts, and I wanted to handle it in follow up tickets (but again it'll take some time to prepare a PR).