[Paid] [$250] Android - Wallet - "Get physical card" button overlaps with device navigation bar

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh1411002@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Device navigation is buttons and not gestures.
• User has been assigned a physical Expensify card.

1. Launch ND or hybrid app.
2. Go to Wallet.
3. Tap on the physical card.

Expected Result:

"Get physical card" button will not overlap with device navigation bar.

Actual Result:

"Get physical card" button overlaps with device navigation bar.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6685385_1733419664616.1733419531016_Screen_Recording_20241206_012359_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866268126921141487
• Upwork Job ID: 1866268126921141487
• Last Price Increase: 2024-12-09
• Automatic offers:
• FitseTLT | Contributor | 105374034

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Get physical card" button overlaps with device navigation bar.

What is the root cause of that problem?

In ExpensifyCardPage component we are setting includeSafeAreaPaddingBottom as false

App/src/pages/settings/Wallet/ExpensifyCardPage.tsx

Line 162 in 2479379

includeSafeAreaPaddingBottom={false}

What changes do you think we should make in order to solve the problem?

We should pass includeSafeAreaPaddingBottom as true

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Wallet - "Get physical card" button overlaps with device navigation bar

What is the root cause of that problem?

This happens because we have set includeSafeAreaPaddingBottom to false here

App/src/pages/settings/Wallet/ExpensifyCardPage.tsx

Line 162 in 2479379

includeSafeAreaPaddingBottom={false}

This is set to false because we are setting safeAreaPaddingBottomStyle style to the scroll view here

App/src/pages/settings/Wallet/ExpensifyCardPage.tsx

Lines 165 to 171 in 48b80f6

	{({safeAreaPaddingBottomStyle}) => (
	<>
	<HeaderWithBackButton
	title={pageTitle}
	onBackButtonPress={() => Navigation.goBack()}
	/>
	<ScrollView contentContainerStyle={safeAreaPaddingBottomStyle}>

but the all the buttons are not children of the scroll view so the safe padding will not be applied for them.

What changes do you think we should make in order to solve the problem?

The best approach is to enable includeSafeAreaPaddingBottom on the screen wrapper as it is the highest parent in the page. So remove this

App/src/pages/settings/Wallet/ExpensifyCardPage.tsx

Line 162 in 2479379

includeSafeAreaPaddingBottom={false}

and then also remove safeAreaPaddingBottomStyle here

App/src/pages/settings/Wallet/ExpensifyCardPage.tsx

Line 165 in 48b80f6

{({safeAreaPaddingBottomStyle}) => (

and render the children of the screen wrapper directly not function (as we no more need safeAreaPaddingBottomStyle) 👍

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[melvin-bot]

@RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[RachCHopkins]

Yes, can repro. It's a PITA too, because when you click activate physical card, you tap the main home button - I thought the app was crashing at first!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866268126921141487