[HOLD for payment 2025-02-04] [$250] Search - Expense from the list does not disappear after deletion

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5309274
Email or phone of affected tester (no customers): sustinov@applausemail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Open HybridApp
2. Log in to the HT account
3. Send 2 manual expenses to any user
4. Go to Search -> Expenses -> All
5. Delete one of the created expenses from step 3
6. Tap again on the deleted expense

Expected Result:

After deleting an expense, it should immediately disappear from the list without refreshing the page

Actual Result:

Expense from the list does not disappear after deletion

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6685819_1733443178341.ScreenRecording_12-06-2024_04-50-37_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021865183017070238528
• Upwork Job ID: 1865183017070238528
• Last Price Increase: 2024-12-13
• Automatic offers:
• rayane-djouah | Reviewer | 105373332
• FitseTLT | Contributor | 105373334

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense from the list does not disappear after deletion

What is the root cause of that problem?

In useSearchHighlightAndScroll, we only update Search data if new transaction is added, not when a transaction is deleted:

App/src/hooks/useSearchHighlightAndScroll.ts

Line 42 in b9107bf

if (transactionsLength && typeof previousTransactionsLength === 'number' && transactionsLength > previousTransactionsLength) {

What changes do you think we should make in order to solve the problem?

Change condition to update Search data if number of transaction is different:

App/src/hooks/useSearchHighlightAndScroll.ts

Line 42 in b9107bf

if (transactionsLength && typeof previousTransactionsLength === 'number' && transactionsLength > previousTransactionsLength) {

        if (transactionsLength && typeof previousTransactionsLength === 'number' && transactionsLength !== previousTransactionsLength) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-12-06 15:01:26 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Expense from the list does not disappear after deletion

What is the root cause of that problem?

We only send search request if there is an increase in transaction length, i.e. the currentTransaction length is greater than the previous transaction length

App/src/hooks/useSearchHighlightAndScroll.ts

Line 42 in b9107bf

if (transactionsLength && typeof previousTransactionsLength === 'number' && transactionsLength > previousTransactionsLength) {

but here we are deleting the expense that will decrease the transactions length we have

What changes do you think we should make in order to solve the problem?

The conditions that depend on transaction length are incorrect in both

App/src/hooks/useSearchHighlightAndScroll.ts

Line 42 in b9107bf

if (transactionsLength && typeof previousTransactionsLength === 'number' && transactionsLength > previousTransactionsLength) {

App/src/hooks/useSearchHighlightAndScroll.ts

Line 37 in b9107bf

if (searchTriggeredRef.current || previousTransactionsLength === transactionsLength) {

because transaction length equality can even mean there is a change that needs a search request to be sent. For instance, if a user creates a new expense but deletes another expense which could result in the transaction lengths to be equal but still there is a change that requires a fetch.
We should instead depend on a condition where the previous and current transaction IDs list are not equal (of course with deep comparison between the values they hold)

App/src/hooks/useSearchHighlightAndScroll.ts

Lines 76 to 80 in b9107bf

	const previousTransactionIDs = extractTransactionIDsFromSearchResults(previousSearchResults);
	const currentTransactionIDs = extractTransactionIDsFromSearchResults(searchResults.data);
	// Find new transaction IDs that are not in the previousTransactionIDs and not already highlighted
	const newTransactionIDs = currentTransactionIDs.filter((id) => !previousTransactionIDs.includes(id) && !highlightedTransactionIDs.current.has(id));

const previousTransactionIDs = previousTransactions && Object.keys(previousTransactions);
        const transactionIDs = transactions && Object.keys(transactions);

and replace this with it

App/src/hooks/useSearchHighlightAndScroll.ts

Line 42 in b9107bf

if (transactionsLength && typeof previousTransactionsLength === 'number' && transactionsLength > previousTransactionsLength) {

if(!isEqual(transactionIDs, previousTransactionIDs))

we can optionally add more condition of the existence of previous transaction ids and current transactionIDs to exclude the case where the values are undefined on first render 👍
and remove the condition here

App/src/hooks/useSearchHighlightAndScroll.ts

Line 37 in b9107bf

if (searchTriggeredRef.current || previousTransactionsLength === transactionsLength) {

        if (searchTriggeredRef.current) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can render the Search page (or optionally test only useSearchHighlightAndScroll) and change the transaction list from onyx by replacing a transaction with another one and mock our SearchActions.search and assert that it has been called 👍

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021865183017070238528

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[mallenexpensify]

@rayane-djouah can you attempt reproduction and, if you're able to, review the above proposals? I tried to test and staging.new.expensify.com froze for me :/

[rayane-d]

Reproducible

Screen.Recording.2024-12-10.at.1.52.09.AM.mov