[HOLD for 56812] [MEDIUM] iOS - Troubleshoot- The "Client side logging" toggle is automatically turned off

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team

Action Performed:

1. Launch the app
2. Navigate to the Troubleshoot in the Settings
3. Turn on the Client side logging toggle
4. Tap the View debug console button
5. Tap the Share log button
6. Select the chat and send a log
7. Return the Troubleshoot

Expected Result:

The "Client side logging" toggle is turned on.

Actual Result:

After sharing a log, the "Client side logging" toggle is automatically turned off and can't be toggled on by the first try.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866259215454556892
• Upwork Job ID: 1866259215454556892
• Last Price Increase: 2024-12-09

Issue Owner

Current Issue Owner: @zfurtak

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The client side logging toggle is switched off again after sharing the log.

What is the root cause of that problem?

This is similar to #50554. Based on the PR explanation, the style on the UI thread is lost. This happens when our FreezeWrapper freezes the screen.

App/src/components/withPrepareCentralPaneScreen/index.native.tsx

Lines 4 to 10 in b595f5d

	/**
	* This higher-order function is dependent on the platform. On native platforms, screens that aren't already displayed in the navigation stack should be frozen to prevent unnecessary rendering.
	* It's handled this way only on mobile platforms because on the web, more than one screen is displayed in a wide layout, so these screens shouldn't be frozen.
	*/
	export default function withPrepareCentralPaneScreen(lazyComponent: () => React.ComponentType) {
	return freezeScreenWithLazyLoading(lazyComponent);
	}

In our case, the switch depends on the offsetX shared value to animate the style using useAnimatedStyle.

App/src/components/Switch.tsx

Lines 38 to 61 in b595f5d

	const offsetX = useSharedValue(isOn ? OFFSET_X.ON : OFFSET_X.OFF);
	const theme = useTheme();
	useEffect(() => {
	offsetX.set(withTiming(isOn ? OFFSET_X.ON : OFFSET_X.OFF, {duration: 300}));
	}, [isOn, offsetX]);
	const handleSwitchPress = () => {
	InteractionManager.runAfterInteractions(() => {
	if (disabled) {
	disabledAction?.();
	return;
	}
	onToggle(!isOn);
	});
	};
	const animatedThumbStyle = useAnimatedStyle(() => ({
	transform: [{translateX: offsetX.get()}],
	}));
	const animatedSwitchTrackStyle = useAnimatedStyle(() => ({
	backgroundColor: interpolateColor(offsetX.get(), [OFFSET_X.OFF, OFFSET_X.ON], [theme.icon, theme.success]),
	}));

What changes do you think we should make in order to solve the problem?

I think this is best to be fixed on the reanimated repo, but in case we want to fix it on our app, we can toggle the offsetX value on/off every time the screen is unfrozen. react-freeze uses Suspense which based on the doc, it will trigger useLayoutEffect when unsuspended.

useLayoutEffect(() => {
    offsetX.set(!isOn ? OFFSET_X.ON : OFFSET_X.OFF);
    offsetX.set(isOn ? OFFSET_X.ON : OFFSET_X.OFF);
}, []);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866259215454556892

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[Christinadobrzyn]

Oh interesting! I think this should be fixed so adding an External label