[HOLD for payment 2024-12-19] [HOLD for payment 2024-12-17] Create workspace - Edit avatar modal is blocking the avatar

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.73-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+23i0230@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Workspaces
3. Click New workspace
4. Click on avatar
5. Upload an avatar
6. Click on the custom avatar

Expected Result:

The edit avatar modal will not block the avatar

Actual Result:

The edit avatar modal is blocking the avatar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6689092_1733764303863.avatar.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The edit avatar modal is blocking the avatar

What is the root cause of that problem?

We are passing shouldUseStyleUtilityForAnchorPosition as true in here. it leads to edit avatar modal will block the avatar

App/src/pages/workspace/WorkspaceConfirmationPage.tsx

Line 135 in c657371

shouldUseStyleUtilityForAnchorPosition

What changes do you think we should make in order to solve the problem?

We should remove this prop

App/src/pages/workspace/WorkspaceConfirmationPage.tsx

Line 135 in c657371

shouldUseStyleUtilityForAnchorPosition

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[MarioExpensify]

I'm removing the deploy blocker on this one as this is just an UI issue that is not preventing from the user to actually change the avatar or moving forward.

[luacmartins]

Let's track down the offending PR and have the original authors fix this

[luacmartins]

Seems to come from #52164
@Krishna Gupta