[HOLD for payment 2025-01-15] [$250] Notification displays the `@expensify.sms` domain in the title alongside the phone number.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.73-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Log in with a phone number as User A.
2. Log in with any other account as User B.
3. Send a message from User A to User B.
4. On User B's device, the notification includes [@expensify.sms](mailto:@expensify.sms)` along with the phone number.

Expected Result:

Notification should display only the sender's phone number.

Actual Result:

Notification includes both the @expensify.sms domain and the sender's phone number.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866600416959560133
• Upwork Job ID: 1866600416959560133
• Last Price Increase: 2024-12-10
• Automatic offers:
• truph01 | Contributor | 105376447

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866600416959560133

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[truph01]

Edited by proposal-police: This proposal was edited at 2024-12-11 00:24:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Notification includes both the @expensify.sms domain and the sender's phone number.

What is the root cause of that problem?

• The notification's title is from:

App/src/libs/Notification/LocalNotification/BrowserNotifications.ts

Line 102 in d9be98d

const plainTextPerson = person?.map((f) => f.text).join() ?? '';

and we didn't remove the sms domain in here.

What changes do you think we should make in order to solve the problem?

• In here we should remove the sms domain by using Str.removeSMSDomain(f.text).

• Similar should be applied in other platform.

• We can check Str.isSMSLogin before removing sms domain.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

• We can use LocalePhoneNumber.formatPhoneNumber(f.text) as well.

[parasharrajat]

I believe this can be solved at the backend. It is a backend issue.

🎀 👀 🎀 C+ reviewed