[Due for payment 2025-02-13] [$250] Expense -Categorized track expense can´t be deleted from report but can be deleted on search

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+91@gmail.com
Issue reported by: Applause - Internal Team
Component Money Requests

Action Performed:

1. Open the staging.new.expensify.com website
2. Open self DM
3. Tap on "+" button and select "Track Expense"
4. Complete the creation flow
5. Once navigated to chat, tap on "Categorize it"
6. Select any category
7. Add a merchant
8. Submit the expense to any workspace
9. Once navigated to workspace chat, long tap on the submitted expense and search for the "Delete Expense" option
10. Open the expense report
11. Tap on the header and look for the "Delete Expense" option
12. Go to search section
13. Long tap over the expense and delete it

Expected Result:

The user should be able to delete the tracked expense from context menu on chat, from report header or from search section

Actual Result:

"Delete Expense" option is not displayed on context menu or on report header after submitting a categorized track expense, but the expense can be deleted from search section

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6692275_1734013745016.No_Delete.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021867523445838450965
• Upwork Job ID: 1867523445838450965
• Last Price Increase: 2025-01-27
• Automatic offers:
• FitseTLT | Contributor | 105912691

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Tony-MK]

Edited by proposal-police: This proposal was edited at 2024-12-20 12:01:06 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense -Categorized track expense can´t be deleted from report but can be deleted on search

What is the root cause of that problem?

The canAddOrDeleteTransactions function returns false early because the policy has autoReporting set to instant and approvalMode set to optional and it doesn't expect hasOnlyNonReimbursableTransactions to return false a for moneyRequestReport like this.

App/src/libs/ReportUtils.ts

Lines 1825 to 1828 in e27c5ea

	const policy = getPolicy(moneyRequestReport?.policyID);
	if (PolicyUtils.isInstantSubmitEnabled(policy) && PolicyUtils.isSubmitAndClose(policy) && hasOnlyNonReimbursableTransactions(moneyRequestReport?.reportID)) {
	return false;
	}

This is because transaction?.reimbursable was initially set as false and has not been adjusted by either the FE or BE.

App/src/libs/TransactionUtils/index.ts

Lines 551 to 556 in 78337bd

	/**
	* Return the reimbursable value. Defaults to true to match BE logic.
	*/
	function getReimbursable(transaction: Transaction): boolean {
	return transaction?.reimbursable ?? true;
	}

What changes do you think we should make in order to solve the problem?

We should either merge reimbursable as true or delete the reimbursable attribute from the original transaction and its draft whichever is more reasonable for the transaction.

In getDeleteTrackExpenseInformation, let's extend the shouldDeleteTransactionFromOnyx if statement with an else if statement checking if isMovingTransactionFromTrackExpense is true like the snippet below.

if (shouldDeleteTransactionFromOnyx){
    ....
} else if (isMovingTransactionFromTrackExpense) {
    optimisticData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
        value: {reimbursable: true}, // OR {reimbursable: null}
    });

    optimisticData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`,
        value: {reimbursable: true}, // OR {reimbursable: null}
    });
}

This will fix the bug while the user is offline but we have to fix the backend to do the same to prevent it from occurring while online.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021867523445838450965

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Current assignee @sonialiap is eligible for the Bug assigner, not assigning anyone new.