[Due for payment 2025-02-13] [$250] $0 doesn't save in the Receipt required amount field in Workspaces

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.76-12
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @zsgreenwald
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Enable Rules under more features in a controlled workspace
2. Navigate to Rules in LHN
3. Click Receipt required amount field and enter $0 as amount
4. Click Save

Expected Result:

User able to save the amount. (In Classic, an admin has the ability to set the Receipt required amount to $0 to effective set a requirement on all imported CC transactions)

Actual Result:

User unable to save the $0 as amount

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

CleanShot.2024-12-16.at.15.14.23.mp4

Recording.852.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021869497589885449250
• Upwork Job ID: 1869497589885449250
• Last Price Increase: 2025-01-01
• Automatic offers:
• allgandalf | Reviewer | 105598691
• nkdengineer | Contributor | 105598693

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-12-18 13:05:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

$0 doesn't save in the Receipt required amount field in Workspaces

What is the root cause of that problem?

We are displaying empty string if the maxExpenseAmountNoReceipt is falsy here

App/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

Lines 91 to 92 in 4b0f250

	if (policy?.maxExpenseAmountNoReceipt === CONST.DISABLED_MAX_EXPENSE_VALUE || !policy?.maxExpenseAmountNoReceipt) {
	return '';

and also here

App/src/pages/workspace/rules/RulesReceiptRequiredAmountPage.tsx

Line 38 in 4b0f250

policy?.maxExpenseAmountNoReceipt === CONST.DISABLED_MAX_EXPENSE_VALUE || !policy?.maxExpenseAmountNoReceipt

but 0 is falsy

What changes do you think we should make in order to solve the problem?

We should check for the type instead for both cases

        if (policy?.maxExpenseAmountNoReceipt === CONST.DISABLED_MAX_EXPENSE_VALUE || typeof policy?.maxExpenseAmountNoReceipt !== 'number') {

        policy?.maxExpenseAmountNoReceipt === CONST.DISABLED_MAX_EXPENSE_VALUE || typeof policy?.maxExpenseAmountNoReceipt !== 'number'

Note: I have seen similar problems with maxExpenseAmount here and here and for maxExpenseAge here and here policyCategory.maxExpenseAmount here and here. The BE allows the values to be set to 0 value but we are displaying empty string so we can apply similar fix as above for these cases too. But if this cases are different from maxExpenseAmountNoReceipt and we don't want to allow zero value then we should update the BE to disallow it and also update our FE code to disallow it and show error on validate but in the scope of this issue on maxExpenseAmountNoReceipt we are sure 0 is allowed so we can apply the above fix 👍

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test IndividualExpenseRulesSection and PolicyRulesPage by setting maxExpenseAmountNoReceipt to 0 and asserting 0 is displayed not empty string.

What alternative solutions did you explore? (Optional)

optionally use a check of undefined

[huult]

Edited by proposal-police: This proposal was edited at 2025-01-02 04:46:31 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

$0 doesn't save in the Receipt required amount field in Workspaces

What is the root cause of that problem?

We are checking if !maxExpenseAmountNoReceipt, !maxExpenseAmount, and !maxExpenseAge, then return ''. Therefore, if the value is 0, these will return '' based on this condition.

App/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

Lines 91 to 93 in d5aa1bd

	if (policy?.maxExpenseAmountNoReceipt === CONST.DISABLED_MAX_EXPENSE_VALUE || !policy?.maxExpenseAmountNoReceipt) {
	return '';
	}

App/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

Lines 99 to 101 in d5aa1bd

	if (policy?.maxExpenseAmount === CONST.DISABLED_MAX_EXPENSE_VALUE || !policy?.maxExpenseAmount) {
	return '';
	}

App/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

Lines 107 to 109 in d5aa1bd

	if (policy?.maxExpenseAge === CONST.DISABLED_MAX_EXPENSE_VALUE || !policy?.maxExpenseAge) {
	return '';
	}

App/src/pages/workspace/rules/RulesReceiptRequiredAmountPage.tsx

Lines 37 to 40 in 286b679

	const defaultValue =
	policy?.maxExpenseAmountNoReceipt === CONST.DISABLED_MAX_EXPENSE_VALUE || !policy?.maxExpenseAmountNoReceipt
	? ''
	: CurrencyUtils.convertToFrontendAmountAsString(policy?.maxExpenseAmountNoReceipt, policy?.outputCurrency);

App/src/pages/workspace/rules/RulesMaxExpenseAmountPage.tsx

Lines 37 to 40 in 286b679

	const defaultValue =
	policy?.maxExpenseAmount === CONST.DISABLED_MAX_EXPENSE_VALUE || !policy?.maxExpenseAmount
	? ''
	: CurrencyUtils.convertToFrontendAmountAsString(policy?.maxExpenseAmount, policy?.outputCurrency);

What changes do you think we should make in order to solve the problem?

So we shouldn’t accept a 0 value when the user inputs it. We should validate the form and return an error like ‘Invalid amount’ if the value is 0. Something like this:

App/src/pages/workspace/rules/RulesReceiptRequiredAmountPage.tsx

Line 41 in 286b679

Add this function:

    const validate = useCallback(
        (values: FormOnyxValues<typeof ONYXKEYS.FORMS.RULES_REQUIRED_RECEIPT_AMOUNT_FORM>) => {
            const errors: FormInputErrors<typeof ONYXKEYS.FORMS.RULES_REQUIRED_RECEIPT_AMOUNT_FORM> = {};
            const maxExpenseAmountNoReceipt = values[INPUT_IDS.MAX_EXPENSE_AMOUNT_NO_RECEIPT];

            if (maxExpenseAmountNoReceipt === '0') {
                errors.maxExpenseAmountNoReceipt = translate('workspace.rules.individualExpenseRules.errors.invalidAmount');
            }

            return errors;
        },
        [translate],
    );

App/src/pages/workspace/rules/RulesReceiptRequiredAmountPage.tsx

Line 57 in 286b679

<FormProvider

update ScreenWrapper to:

      <FormProvider
          style={[styles.flexGrow1, styles.ph5]}
          formID={ONYXKEYS.FORMS.RULES_REQUIRED_RECEIPT_AMOUNT_FORM}
          onSubmit={({maxExpenseAmountNoReceipt}) => {
              PolicyActions.setPolicyMaxExpenseAmountNoReceipt(policyID, maxExpenseAmountNoReceipt);
              Navigation.setNavigationActionToMicrotaskQueue(Navigation.goBack);
          }}
          submitButtonText={translate('workspace.editor.save')}
          enabledWhenOffline
          validate={validate}
      >

We can apply this solution to other similar cases, such as maxExpenseAmount ...

POC

• 

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We created a test for validate to check if the amount is 0. If it is, then errors.maxExpenseAmountNoReceipt should have a value. Otherwise, if the amount is not 0, the error should be {}.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Or we can simply return '' for the case DISABLED_MAX_EXPENSE_VALUE (when the user inputs an empty value) to avoid displaying the default max expense value and apply the same logic to the other mentioned cases here and here

App/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx

Line 99 in d5aa1bd

if (policy?.maxExpenseAmount === CONST.DISABLED_MAX_EXPENSE_VALUE || !policy?.maxExpenseAmount) {

        if (policy?.maxExpenseAmount === CONST.DISABLED_MAX_EXPENSE_VALUE) {
            return '';
        }

[FitseTLT]

Updated to add similar fixes for maxExpenseAmount, maxExpenseAge and policyCategory.maxExpenseAmount

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021869497589885449250

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)