[Due for payment 2025-02-18] [$250] Taxes - Tax name disappears in name editor when the tax name has < symbol

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.78-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+909608@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Taxes.
3. Click Add rate.
4. Click Name.
5. Enter "Mileage < 1400 cc" and save it.
6. Enter a rate.
7. Save the new rate.
8. Click on the new rate.
9. Click Name.

Expected Result:

Name field will show the complete tax rate name "Mileage < 1400 cc".

Actual Result:

Name field only shows "Mileage ". Anything behind < is gone.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6702036_1735123824870.20241225_184710.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021873766721283552899
• Upwork Job ID: 1873766721283552899
• Last Price Increase: 2025-01-13
• Automatic offers:
• etCoderDysto | Contributor | 105781153

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

Edited by proposal-police: This proposal was edited at 2024-12-25 15:19:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Taxes - Tax name disappears in name editor when the tax name has < symbol

What is the root cause of that problem?

Here we are using htmlToMarkdown on the tax rate name. And the characters after '<' will be removed.

App/src/pages/workspace/taxes/NamePage.tsx

Line 41 in 12e0941

const [name, setName] = useState(() => Parser.htmlToMarkdown(currentTaxRate?.name ?? ''));

What changes do you think we should make in order to solve the problem?

Since the input doesn't accept html format, and currentTaxRate?.name is not in html format we should remove htmlToMarkdown, and pass currentTaxRate?.name ?? '' directly to the useState.

 const [name, setName] = useState(currentTaxRate?.name ?? '');

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tax name disappears in name editor when the tax name has < symbol

What is the root cause of that problem?

This conversion of html to markdown was added as part of #38208, but here instead of markdown they wanted to convert html > text using htmlToText:

App/src/libs/Parser.ts

Line 56 in 918488a

htmlToText(htmlString: string, extras?: Extras): string {

So in the code below we use htmlToMarkdown which causes the text to get parsed as markdown:

App/src/pages/workspace/taxes/NamePage.tsx

Line 41 in 12e0941

const [name, setName] = useState(() => Parser.htmlToMarkdown(currentTaxRate?.name ?? ''));

What changes do you think we should make in order to solve the problem?

We should use htmlToText instead of htmlToMarkdown and this bug will be solved correctly.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A this is a UI bug and not functional

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021873766721283552899

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)