[Due for payment 2025-03-13] [$500] Web - On leaving thread & tapping back, user directed to previous visited page

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.78-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Start in a DM with someone or any room in a workspace
3. Go to your self DM
4. Send a message and open reply in thread page
5. Comment in the thread
6. Click header to go back to your self DM
7. Tap browser back button

Expected Result:

Land back in the thread

Actual Result:

Land on the DM or room I was in before

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

CleanShot.2025-01-21.at.11.02.49.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021881910352701713160
• Upwork Job ID: 1881910352701713160
• Last Price Increase: 2025-02-19
• Automatic offers:
• allgandalf | Reviewer | 106195677
• daledah | Contributor | 106195679

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-01 15:23:09 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

On leaving thread & tapping back user directed to previous visited page

What is the root cause of that problem?

In

App/src/components/ParentNavigationSubtitle.tsx

Lines 47 to 50 in 9689e56

	Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(parentReportID));
	if (isVisibleAction) {
	// Pop the chat report screen before navigating to the linked report action.
	Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(parentReportID, parentReportActionID), true);

we triggered goBack when users click on the report header, that removes the thread report from navigation stack.

What changes do you think we should make in order to solve the problem?

we should use navigate in this case

 const isVisibleAction = shouldReportActionBeVisible(parentAction, parentAction?.reportActionID ?? CONST.DEFAULT_NUMBER_ID, canUserPerformWriteAction);

                if (isVisibleAction) {
                    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(parentReportID, parentReportActionID));
                }else{
                    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(parentReportID));
                }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

I think this should be considered as expected.

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[anmurali]

@FitseTLT - So #37355 was reverted? And we don't plan to change this behavior?

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[anmurali]

Bumped @FitseTLT here

[melvin-bot]

@anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!