[HOLD for payment 2025-01-15] [$250] Workspace - Features in Workspace LHN are not in the same order as in "More Features" for Invoice

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.78-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Go to a workspace settings
3. Turn on all features in under "More features"
4. Note the order they appear in workspace LHN and in "More features"

Expected Result:

Features in Workspace LHN must be in the same order as in "More Features" for Invoice (as in PR #45555)

Actual Result:

Features in Workspace LHN are not in the same order as in "More Features" for Invoice.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021873772667783214723
• Upwork Job ID: 1873772667783214723
• Last Price Increase: 2024-12-30
• Automatic offers:
• shubham1206agra | Reviewer | 105520836
• nkdengineer | Contributor | 105520837

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-12-25 20:36:07 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Features in Workspace LHN are not in the same order as in "More Features" for Invoice

What is the root cause of that problem?

In workspace initial page, we are not order item in workspace LHN as the same as in "More Features" for Invoice

What changes do you think we should make in order to solve the problem?

We should move the block that define Invoice to the correct position after rules block

App/src/pages/workspace/WorkspaceInitialPage.tsx

Lines 196 to 209 in 918488a

	if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_INVOICES_ENABLED]) {
	const currencyCode = policy?.outputCurrency ?? CONST.CURRENCY.USD;
	protectedCollectPolicyMenuItems.push({
	translationKey: 'workspace.common.invoices',
	icon: Expensicons.InvoiceGeneric,
	action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_INVOICES.getRoute(policyID)))),
	routeName: SCREENS.WORKSPACE.INVOICES,
	badgeText: `${CurrencyUtils.getCurrencySymbol(currencyCode)}${CurrencyUtils.convertToFrontendAmountAsString(
	policy?.invoice?.bankAccount?.stripeConnectAccountBalance ?? 0,
	currencyCode,
	)}`,
	});
	}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021873772667783214723

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)