[HOLD for payment 2025-01-13] [HOLD for payment 2025-01-07] Chat - App crashes when creating group chat offline and returning online on report details RHP

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh1012032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Chat Report View

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Open FAB > Start chat.
4. Create a group chat with any user.
5. Click on the group chat header.
6. Go online.

Expected Result:

App will not crash.

Actual Result:

App crashes when creating group chat offline and returning online on report details RHP.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6702687_1735252105900.group.mp4

Bug6702687_1735252105899!crash.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[thelullabyy]

Edited by proposal-police: This proposal was edited at 2024-12-27 07:24:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when creating group chat offline and returning online on report details RHP.

What is the root cause of that problem?

It caused by this PR, we don't add default value

What changes do you think we should make in order to solve the problem?

App/src/pages/ReportDetailsPage.tsx

Line 90 in e94df0f

const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`);

We need to add default value and use ?. access to this line

report?.parentReportID ?? CONST.DEFAULT_NUMBER_ID

Also need to fix all other places with same way

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)