[HOLD for payment 2025-01-28] [$250] Web - Profile - App takes user back two steps when double clicking on a pronoun

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.80-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to Settings > Profile > Pronouns
2. Search for a pronoun
3. Double click on one of the pronoun options

Expected Result:

The app navigates user back one step only

Actual Result:

Double clicking on the pronoun option takes user back two steps

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021877173821913500606
• Upwork Job ID: 1877173821913500606
• Last Price Increase: 2025-01-09
• Automatic offers:
• shubham1206agra | Contributor | 105628069

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[shubham1206agra]

Edited by proposal-police: This proposal was edited at 2025-01-06 18:53:07 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Profile - App takes user back two steps when double clicking on a pronoun

What is the root cause of that problem?

In

App/src/pages/settings/Profile/PronounsPage.tsx

Line 98 in 119d72b

shouldSingleExecuteRowSelect

We use singleExecution, but it does not work since it is meant for native flow only.

What changes do you think we should make in order to solve the problem?

In https://github.com/Expensify/App/blob/119d72b124b401a7757f4c0b667e5d7278610ed3/src/pages/settings/Profile/PronounsPage.tsx

We should introduce a ref called isOptionSelected that will be true when we select an option, which will prevent the option from being selected multiple times.

Code for updated function

    const updatePronouns = (selectedPronouns: PronounEntry) => {
        if (isOptionSelected.current) {
            return;
        }
        isOptionSelected.current = true;
        PersonalDetails.updatePronouns(selectedPronouns.keyForList === currentPronounsKey ? '' : selectedPronouns?.value ?? '');
        Navigation.goBack();
    };

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA since this is user induced test.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021877173821913500606

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[azr-arch]

The issue occurs because the updatePronouns function

const updatePronouns = (selectedPronouns: PronounEntry) => {
        PersonalDetails.updatePronouns(selectedPronouns.keyForList === currentPronounsKey ? '' : selectedPronouns?.value ?? '');
        Navigation.goBack();
    };

is being called twice when a pronoun option is double-clicked. this results in the Navigation.goBack() to execute twice, hence causing the app to navigate back two steps instead of one.

[melvin-bot]

📣 @azr-arch! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[azr-arch]

Contributor details
Your Expensify account email: dummyaccc023@gmail.com
Upwork Profile Link: Upwork

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!