[HOLD for payment 2025-02-04] [$125] Android - Cards - Next button for company card instruction page is overlapped

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5457021
Email or phone of affected tester (no customers): testpayment935+881@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to More features on workspace settings
2. Enable Company Cards
3. Navigate to Company Cards
4. Click on Add Company card
5. Click on American Express from the list
6. Click Next
7. Select the option for "Corporate Cards" and next
8. Notice the Next button in the bottom

Expected Result:

Next button for instructions to set up the company card feed page don't overlap with navigation bar or scrollable

Actual Result:

Next button for company card instruction page is overlapped with navigation bar and the page is not scrollable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021879607222461961573
• Upwork Job ID: 1879607222461961573
• Last Price Increase: 2025-01-17

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Cards - Next button for company card instruction page is overlapped

What is the root cause of that problem?

We didn't apply the safe area padding bottom in ScrollView:

App/src/pages/workspace/companyCards/addNew/CardInstructionsStep.tsx

Lines 96 to 98 in 3fc71c9

	<ScrollView
	style={styles.pt0}
	contentContainerStyle={styles.flexGrow1}

What changes do you think we should make in order to solve the problem?

We should apply safeAreaPaddingBottomStyle to style or contentContainerStyle in ScrollView:

    const {safeAreaPaddingBottomStyle} = useStyledSafeAreaInsets();

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

We can use includeSafeAreaPaddingBottom={true} in:

App/src/pages/workspace/companyCards/addNew/CardInstructionsStep.tsx

Line 88 in 3fc71c9

includeSafeAreaPaddingBottom={false}

[dukenv0307]

Enable includeSafeAreaPaddingBottom looks promissing

[dukenv0307]

I'm working on WS feed project, I can help take it as C+ @abekkala

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021879607222461961573

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[dukenv0307]

@daledah's alternative solution looks good to me. We can remove includeSafeAreaPaddingBottom={false} since the default value is true.

🎀👀🎀 C+ reviewed