[HOLD for payment 2025-02-05] [$250] Web - Distance - Create a distance to a user display an error message

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.85-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #55220
Email or phone of affected tester (no customers): luongquocvu92@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Chat Report View

Action Performed:

1. Open the http://staging.new.expensify.com/
2. Click on the FAB
3. Click on the Create expense
4. Click on the Distance
5. Select location over 44 Kilometers
6. Click the Next button
7. Click on a user DM from the recent list or enter one
8. Click on the Submit button

Expected Result:

The web should allow the user to create the distance expense normally

Actual Result:

When creating a distance and submit to an individual user it displays an error message

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6714487_1736919221563.Invalid_amount_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021879503209059502176
• Upwork Job ID: 1879503209059502176
• Last Price Increase: 2025-01-15
• Automatic offers:
• nkdengineer | Contributor | 105798427

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating a distance and submit to an individual user it displays an error message

What is the root cause of that problem?

We have CONST.IOU.AMOUNT_MAX_LENGTH = 8

With long distances and small currency values ​​the amount here will have more than 8 digits and we get an error

App/src/components/MoneyRequestConfirmationList.tsx

Lines 790 to 793 in 7b9e55e

	if (isDistanceRequest && !isDistanceRequestWithPendingRoute && !MoneyRequestUtils.validateAmount(String(iouAmount), decimals)) {
	setFormError('common.error.invalidAmount');
	return;
	}

App/src/libs/MoneyRequestUtils.ts

Line 47 in 7b9e55e

function validateAmount(amount: string, decimals: number, amountMaxLength: number = CONST.IOU.AMOUNT_MAX_LENGTH, shouldAllowNegative = false): boolean {

What changes do you think we should make in order to solve the problem?

We should pass amount max length for case isDistanceRequest is 10

         validateAmount(String(iouAmount), decimals, 10)) {
              setFormError('common.error.invalidAmount');
              return;
          }

App/src/components/MoneyRequestConfirmationList.tsx

Lines 790 to 793 in 7b9e55e

	if (isDistanceRequest && !isDistanceRequestWithPendingRoute && !MoneyRequestUtils.validateAmount(String(iouAmount), decimals)) {
	setFormError('common.error.invalidAmount');
	return;
	}

We have this PR to fix changing amount max length from 10 to 8 because with amount having more than 10 digits, manual request will fail in BE side.
I tried it in case distance request and there was no problem.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format.

[WoLewicki]

@nkdengineer could you elaborate if the bump of mapbox caused this issue?

[mountiny]

this does not seem related but maybe they just found it as they tested the flow more.

This is is not marked as deploy blocker so probably not

[WoLewicki]

It was linked in my PR: #55220, that's why I'm asking. Thanks for info!

[nkdengineer]

@nkdengineer could you elaborate if the bump of mapbox caused this issue?

@WoLewicki It seems unrelated to your PR, this issue is about us setting amountMaxLength smaller than the amount of the transaction.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021879503209059502176