[Due for payment 2025-02-18] [$500] In the full story user not redirected to #admins Room After Creating Workspace – Stuck in Concierge

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): convert

Action Performed:

1. Choose an accounting package during onboarding
2. Observe that a workspace is created, and the #admins room appears.
3. Note that the user is not redirected to the #admins room automatically.
4. The user remains in the Concierge chat unless they manually navigate to the #admins room.

Expected Result:

Once the workspace is created and the #admins room appears, the user should be automatically redirected to the #admins room for a smoother experience.

Actual Result:

The user remains in the Concierge chat even after the workspace creation, requiring them to find and navigate to the #admins room manually.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Link to Fullstory is in OP

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021880331139770557066
• Upwork Job ID: 1880331139770557066
• Last Price Increase: 2025-01-17
• Automatic offers:
• DylanDylann | Reviewer | 105808765
• mkzie2 | Contributor | 105808769

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user remains in the Concierge chat even after the workspace creation, requiring them to find and navigate to the #admins room manually.

What is the root cause of that problem?

We navigate to Concierge chat, or last accessed report after onboarding, and forcefully block navigate to workspace chats:

App/src/libs/navigateAfterOnboarding.ts

Lines 16 to 21 in 6f1541c

	const lastAccessedReport = ReportUtils.findLastAccessedReport(!canUseDefaultRooms, shouldOpenOnAdminRoom(), activeWorkspaceID);
	const lastAccessedReportID = lastAccessedReport?.reportID;
	// we don't want to navigate to newly creaded workspace after onboarding completed.
	if (!lastAccessedReportID || lastAccessedReport.policyID === onboardingPolicyID || ReportUtils.isConciergeChatReport(lastAccessedReport)) {
	return;
	}

What changes do you think we should make in order to solve the problem?

I think the main problem here is that #admins room is missing from LHN and user cannot find it causing confusions. Concierge chat already has all the necessary setup suggestions to begin with:

However I still propose 2 solutions:

1. Navigate directly to #admins room after choosing the integrated accounting solution (Manage my team's expense onboarding choice)
2. Show #admins room in LHN (my recommendation)

Navigate to #admins room instead of Concierge

Introduce a new param shouldOpenAdminRoom to this function

App/src/libs/navigateAfterOnboarding.ts

Line 6 in 6f1541c

const navigateAfterOnboarding = (isSmallScreenWidth: boolean, canUseDefaultRooms: boolean | undefined, onboardingPolicyID?: string, activeWorkspaceID?: string) => {

And when we find the last access report here, pass the above param to find the admin room:

App/src/libs/navigateAfterOnboarding.ts

Line 16 in 6f1541c

const lastAccessedReport = ReportUtils.findLastAccessedReport(!canUseDefaultRooms, shouldOpenOnAdminRoom(), activeWorkspaceID);

shouldOpenAdminRoom ?? shouldOpenOnAdminRoom()

And pass shouldOpenAdminRoom as true in BaseOnboardingAccounting:

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Line 185 in a0afb37

navigateAfterOnboarding(isSmallScreenWidth, shouldUseNarrowLayout, canUseDefaultRooms, onboardingPolicyID, activeWorkspaceID, route.params?.backTo);

Show #admins room in LHN

Modify the shouldAdminRoomsBeVisible here to include this condition:

App/src/libs/ReportUtils.ts

Line 6673 in 5133090

function shouldAdminsRoomBeVisible(report: OnyxEntry<Report>): boolean {

if (onboardingPurposeSelected === 'newDotManageTeam' && getActiveAdminWorkspaces(allPolicies, currentUserEmail).length === 1) {
    return true;
}

So that if it was the only #admins room and the onboarding choice was Manage my team's expenses, we would show it.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[DylanDylann]

I can reproduce this issue. Should I take over this issue as C+ as mentioned here

the correct steps:

1. Login with new Account
2. Waiting for the Onboarding modal appears
3. Select "Manage my team..." and complete the flow

Screen.Recording.2025-01-16.at.15.59.48.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021880331139770557066

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.