[Due for payment 2025-02-13] [$250] Copilot - Not so fast modal disappear quickly & DM chat page becomes unresponsive

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.88-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5491796
Email or phone of affected tester (no customers): applausetester+ck1111@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 16/iOS 18
App Component: Other

Action Performed:

Precondition: User has setup copilot with limited access

1. Launch Hybrid app
2. Login as the account that has limited copilot access
3. Navigate to settings
4. Click on the account switcher'
5. Click on the account that added the user as copilot
6. Navigate to any 1:1 conversation
7. Tap + icon in composer >> Select Pay option (Note : Not so fast modal appear briefly & disappears immediately)
8. Try clicking the + icon, composer input field, search icon, back button Or emoji icon

Expected Result:

On step 7 - Not so fast modal should be visible completely with Got it button. The modal should not disappear immediately
On step 8 - 1:1 chat page should be responsive

Actual Result:

On step 7 - Not so fast modal appears briefly and disppear very quickly
On step 8 - 1:1 chat page not responsive

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6720377_1737496554677.ScreenRecording_01-21-2025_16-39-27_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021882960227417313839
• Upwork Job ID: 1882960227417313839
• Last Price Increase: 2025-01-25
• Automatic offers:
• paultsimura | Reviewer | 105908430
• daledah | Contributor | 105908431

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On step 7 - Not so fast modal appears briefly and disppear very quickly
On step 8 - 1:1 chat page not responsive

What is the root cause of that problem?

When clicking "Pay ...", we open the DelegateNoAccessModal:

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 152 to 155 in a0836a9

	if (isDelegateAccessRestricted) {
	setIsNoDelegateAccessMenuVisible(true);
	return;
	}

Delegate modal is opened before Popover menu is closed, which leads to modal props is false:

But isNoDelegateAccessMenuVisible is also true, so the modal is still opened, which makes the focus trap is still enabled, while its content is hidden

What changes do you think we should make in order to solve the problem?

We should wrap the delegate logic inside Modal.close, similar to other places

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 152 to 155 in a0836a9

	if (isDelegateAccessRestricted) {
	setIsNoDelegateAccessMenuVisible(true);
	return;
	}

if (isDelegateAccessRestricted) {
   close(() => {
       setIsNoDelegateAccessMenuVisible(true);
   });
   return;
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA, UI Bug

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-22 13:06:32 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not so fast modal disappear quickly & DM chat page becomes unresponsive

What is the root cause of that problem?

Here

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 151 to 154 in a0836a9

	onSelected: () => {
	if (isDelegateAccessRestricted) {
	setIsNoDelegateAccessMenuVisible(true);
	return;

we are displaying the DelegateNoAccessModal on top of PopoverMenu when we click Pay option from menu it indeed set the isNoDelegateAccessMenuVisible true

setIsNoDelegateAccessMenuVisible(true);

but at the same time PopoverMenu get closed that hide DelegateNoAccessModal even it's still true and not closed properly, that lead to make chat page unresponsive.

What changes do you think we should make in order to solve the problem?

we should keep the PopoverMenu visible, so user can close the DelegateNoAccessModal manually.

if (isDelegateAccessRestricted) {
     setIsNoDelegateAccessMenuVisible(true);
     setMenuVisibility(true);
     return;
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Screen.Recording.2025-01-22.at.5.33.13.PM.mov

[github-actions]

⚠️ @samranahm Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021882960227417313839

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)