[Due for payment 2025-03-13] [$250] The "Success" sound isn't played when you approve a report

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.89-2
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): Expensify-bugs

Action Performed:

1. Submit an expense
2. Approve the expense as a approver

Expected Result:

Success notification heard

Actual Result:

No success notification

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884130281314899150
• Upwork Job ID: 1884130281314899150
• Last Price Increase: 2025-01-28
• Automatic offers:
• allgandalf | Contributor | 105941078

Issue Owner

Current Issue Owner: @alexpensify / @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Success" sound isn't played when you approve a report

What is the root cause of that problem?

The "Success" sound was not implemented when approving a report, resulting in the absence of the "Success" sound effect.

What changes do you think we should make in order to solve the problem?

We should call playSound(SOUNDS.SUCCESS) before making the APPROVE_MONEY_REQUEST API request to ensure the sound plays when a report is approved.

App/src/libs/actions/IOU.ts

Lines 8108 to 8109 in d930fea

	API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST, parameters, {optimisticData, successData, failureData});

    playSound(SOUNDS.SUCCESS);
    API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST, parameters, {optimisticData, successData, failureData});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Alternatively, we could add the playSound call inside the confirmApproval functions before invoking the approveMoneyRequest IOU action. However, since this action is used in multiple places, I prefer the solution of calling playSound directly inside the approveMoneyRequest action.

Example

App/src/components/ReportActionItem/ReportPreview.tsx

Line 311 in d930fea

approveMoneyRequest(iouReport, true);

            playSound(SOUNDS.SUCCESS);
            approveMoneyRequest(iouReport, true);

This is a list of places where approve a report is called:
MoneyReportHeader,
ProcessMoneyReportHoldMenu,
ReportPreview,
SettlementButton

Detail

[allgandalf]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 04:45:53 UTC.

Note

To any C+ getting assigned please review my proposal here as well, as it is technically first in queue 😅

Also c.c. @mallenexpensify as the process is yet to be documented from here

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add success sound when approving and expense/report

What is the root cause of that problem?

Feature Request

What changes do you think we should make in order to solve the problem?

We would need to use playSound(SOUNDS.SUCCESS); at the following places:

App/src/libs/actions/Search.ts

Lines 314 to 316 in ddd644f

	API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST_ON_SEARCH, {hash, reportIDList}, {optimisticData, failureData, finallyData});
	}

and

App/src/libs/actions/IOU.ts

Lines 8070 to 8072 in ddd644f

	API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST, parameters, {optimisticData, successData, failureData});
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A this is a simple bug to play sound

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884130281314899150

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)