[Due for payment 2025-02-13] [$250] Role description is missing in the members invite confirmation page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.89-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): convert

Action Performed:

1. Go to workspace
2. Click invite members
3. select any member and go to the confirmation page
4. Click on the "role"

Expected Result:

Each role should have description as we do in the members page

Actual Result:

Description is missing

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884053294928345756
• Upwork Job ID: 1884053294928345756
• Last Price Increase: 2025-01-28
• Automatic offers:
• twilight2294 | Contributor | 105891675

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884053294928345756

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Role description is missing in the members invite confirmation page

What is the root cause of that problem?

Because alternateText is not added here:

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 133 to 138 in e66284f

	const roleItems = useMemo(() => {
	return Object.values(CONST.POLICY.ROLE).map((roleValue) => {
	let label = '';
	if (roleValue === CONST.POLICY.ROLE.USER) {
	label = translate('common.member');
	} else if (roleValue === CONST.POLICY.ROLE.ADMIN) {

like it is added here:

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Line 121 in e66284f

alternateText: translate('workspace.common.memberAlternateText'),

What changes do you think we should make in order to solve the problem?

Add the same alternateText for each role in the WorkspaceInviteMessagePage

    const roleItems = useMemo(() => {
        return Object.values(CONST.POLICY.ROLE).map((roleValue) => {
            let label = '';
            let description = '';
            if (roleValue === CONST.POLICY.ROLE.USER) {
                label = translate('common.member');
                description = translate('workspace.common.memberAlternateText')
            } else if (roleValue === CONST.POLICY.ROLE.ADMIN) {
                label = translate('common.admin');
                description = translate('workspace.common.adminAlternateText')
            } else {
                label = translate('common.auditor');
                description = translate('workspace.common.auditorAlternateText')
            }
            return {
                label,
                value: roleValue,
                description,
            };
        });
    }, [translate]);

As the description of the admin role is lengthy we have to pass the isAlternateTextMultilineSupported prop to the InputWrapper , and then in the ValuePicker to the ValueSelectorModal and in the ValueSelectorModal to the isAlternateTextMultilineSupported

or we can simply pass isAlternateTextMultilineSupported prop to the

App/src/components/ValuePicker/ValueSelectorModal.tsx

Lines 50 to 52 in 50df6eb

	<SelectionList
	sections={sections}
	onSelectRow={(item) => onItemSelected?.(item)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Screen.Recording.2025-01-28.at.7.43.11.AM.mov

[twilight2294]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-28 08:30:48 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Role description is missing in the members invite confirmation page

What is the root cause of that problem?

We are using InputWrapper to display the role and ValuePicker to list the items present for role, which is wrong as we already have WorkspaceMemberDetailsRoleSelectionModal defined to make this selection. So to solve this issue we need to reuse the same modal

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Line 206 in e66284f

<InputWrapper

What changes do you think we should make in order to solve the problem?

So replace InputWrapper with WorkspaceMemberDetailsRoleSelectionModal as we should keep the code DRY and reuse existing modals:

App/src/pages/workspace/members/WorkspaceMemberDetailsRoleSelectionModal.tsx

Line 35 in 75bf54e

function WorkspaceMemberDetailsRoleSelectionModal({isVisible, items, onRoleChange, onClose}: WorkspaceMemberDetailsPageProps) {

We also need to include alternateText here to display the role description.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A UI bug

What alternative solutions did you explore? (Optional)

N/A

[sobitneupane]

Thanks everyone for the proposal.

As we already have WorkspaceMemberDetailsRoleSelectionModal for role selection, let's reuse it. It would be better to rename it to WorkspaceMemberRoleSelectionModal and move it to the workspace folder. Proposal from @twilight2294 looks good to me.

🎀 👀 🎀 C+ reviewed