[Due for payment 2025-03-13] [$250] Android - Tax - After entering zero dot cursor thickness is changed

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Workspace Settings

Action Performed:

1. Launch app
2. Go to workspace settings -more features
3. Enable taxes
4. Tap taxes - add rate - value
5. Note the cursor thickness
6. Enter 0. Or 0.0 and then note the cursor thickness

Expected Result:

After entering zero dot cursor thickness must not be changed .

Actual Result:

After entering zero dot cursor thickness is changed .

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6725782_1738040732107.Screenrecorder-2025-01-28-10-30-48-772.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021885202274440489837
• Upwork Job ID: 1885202274440489837
• Last Price Increase: 2025-02-21
• Automatic offers:
• wildan-m | Contributor | 106280129

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The input cursor width becomes thin after entering a digit.

What is the root cause of that problem?

This is caused by the padding right style added to the input here.

App/src/components/TextInputWithCurrencySymbol/BaseTextInputWithCurrencySymbol.tsx

Line 64 in 3b90d39

style={[styles.pr1, style]}

This happens to every component that uses TextInputWithCurrencySymbol, except on the money request page because we add an extra space to it.

App/src/pages/iou/MoneyRequestAmountForm.tsx

Line 260 in 3b90d39

autoGrowExtraSpace={variables.w80}

The padding right was first added in this commit. I'm not sure what it fixes, but the only difference with/without the padding is the space between the input and the symbol.

with padding

without padding

What changes do you think we should make in order to solve the problem?

We can simply remove the padding right style. If we still want to have spacing between the input and symbol, we can add a margin to the symbol text.

OR

We can just add an extra spaces too, just like we did on the money request page.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[stephanieelliott]

Took me a couple views to notice the issue, but I agree this looks weird.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021885202274440489837

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)