-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Closed
Closed
Copy link
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionImprovementItem broken or needs improvement.Item broken or needs improvement.WeeklyKSv2KSv2
Description
Problem
The existing experience to resolve conflicts when cherry-picking a PR is a bit wonky. It commits conflict markers, which should not really ever be committed in the code. It also makes it less ergonomic to resolve those conflicts, because they won't appear as such in most git/diff tools.
Solution
In cases where a CP fails due to conflicts, just commit the version bump, and include the CP command in the PR description for the engineer to run manually. Furthermore:
- Ensure the author of the original PR that's being CP'd is assigned, not just the deployer who triggered the CP
- Ensure that we include the PR template (including checklists) and enforce that checklists are completed for these kind of manual CP's
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionImprovementItem broken or needs improvement.Item broken or needs improvement.WeeklyKSv2KSv2