[Due for payment 2025-06-05] [$250] Web - Company cards - User stays on member profile tab instead Company cards page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.91-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3809610
Email or phone of affected tester (no customers): applausetester+ccardfeed@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition: workspace with several members, with enabled Company cards. Some company cards are added.

1. Go to ws > Members
2. Click on member with already assigned company card (if no, assign card to member)
3. Click on 'New card'
4. Proceed to the 4th step 'Let’s double check that everything looks right.'
5. Click on Cardholder field
6. Select another ws member
7. Click 'Assign card'

Expected Result:

User lands to Company cards page, rather than the workspace member profile he was previously on (as you assigned the card to someone else)

Actual Result:

User stays on member's (from step 2) profile tab

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6727880_1738182016138.bandicam_2025-01-29_22-07-17-203.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884789970763850893
• Upwork Job ID: 1884789970763850893
• Last Price Increase: 2025-01-30
• Automatic offers:
• twilight2294 | Contributor | 106071043

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-30 01:09:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User stays on member profile tab instead Company cards page

What is the root cause of that problem?

The navigation inconsistency stems from the use of the backTo parameter, which defaults to redirecting users to the originating page (e.g., a members page) instead of enforcing a consistent post-submission path to the company cards page.

App/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx

Lines 40 to 47 in 6670a4e

	const submit = () => {
	if (!policyID) {
	return;
	}
	CompanyCards.assignWorkspaceCompanyCard(policyID, data);
	Navigation.navigate(backTo ?? ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID));
	CompanyCards.clearAssignCardStepAndData();
	};

What changes do you think we should make in order to solve the problem?

Change the submit function to always navigate to WORKSPACE_COMPANY_CARDS after submission

    const submit = () => {
        if (!policyID) {
            return;
        }
        CompanyCards.assignWorkspaceCompanyCard(policyID, data);
        Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID));  
        CompanyCards.clearAssignCardStepAndData();
    };

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[github-actions]

⚠️ @nyomanjyotisa Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884789970763850893

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User stays on member profile tab instead Company cards page

What is the root cause of that problem?

We are expected to go back to the members page if the card is assigned to the same member from whose profile page we clicked assign cards, but in the current navigation condition, we navigate to the members profile page regardless of the card being assigned to the same / different member:

App/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx

Lines 40 to 47 in 6670a4e

	const submit = () => {
	if (!policyID) {
	return;
	}
	CompanyCards.assignWorkspaceCompanyCard(policyID, data);
	Navigation.navigate(backTo ?? ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID));
	CompanyCards.clearAssignCardStepAndData();
	};

There is not check to see if the same member was assigned the card.

What changes do you think we should make in order to solve the problem?

According to op:

User lands to Company cards page, rather than the workspace member profile he was previously on (as you assigned the card to someone else)

To achieve this, we need to compare the accountID from the backTo param to the currently selected users accountID:

1. Firstly in ConfirmationStep we need to extract the accountID from the backTo param to get the workspace member from where we initially navigated accountID:
   

   App/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx

   Line 30 in acd7a79

   function ConfirmationStep({policyID, backTo}: ConfirmationStepProps) {

const workspaceMemberAccountID = backTo?.split('/').at(-1);

2. Then we need to get the accountID for the user who is current being getting the card assigned:
   

   App/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx

   Line 38 in acd7a79

   const cardholderName = PersonalDetailsUtils.getPersonalDetailByEmail(data?.email ?? '')?.displayName ?? '';

    const cardholderAccountID = PersonalDetailsUtils.getPersonalDetailByEmail(data?.email ?? '')?.accountID.toString() ?? '';

3. Then we need to update the submit step:
   

   App/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx

   Line 40 in acd7a79

   const submit = () => {

    const submit = () => {
        if (!policyID) {
            return;
        }
        CompanyCards.assignWorkspaceCompanyCard(policyID, data);
        if (backTo) {
            Navigation.navigate(workspaceMemberAccountID === cardholderAccountID ? backTo : ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID));
        } else {
            Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID));
        }

        CompanyCards.clearAssignCardStepAndData();
    };

The above conditions can be improved including the extraction of workspaceMemberAccountID during PR phase

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A this is a navigation bug

What alternative solutions did you explore? (Optional)

[s77rt]

Hi! Thanks for the proposals. I think we need to align on the expected behaviour first and whether this is something we need to actually fix.

Here a slack thread https://expensify.slack.com/archives/C01GTK53T8Q/p1738245718538879