[HOLD https://github.com/Expensify/App/pull/57281] Hybrid - Android - Workflow - No bottom margin after enabling approval and delay submission

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.92-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): testpayment935+893@gmail.com
Issue reported by: Applause Internal Team
Device used: Android
App Component: Workspace Settings

Action Performed:

1. Navigate to android app
2. Create workspace and go to workflow
3. Notice the margin of the bottom
4. Enable add approvals and delay submission ( if you have big screen add 2 or more approvals)
5. Notice the bottom margin and it is not scrollable

Expected Result:

The bottom margin of workflow page fully show

Actual Result:

No bottom margin after enabling approval and delay submission

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6728431_1738233873262.Screen_Recording_20250130_132859_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021885123690732497773
• Upwork Job ID: 1885123690732497773
• Last Price Increase: 2025-01-31

Issue Owner

Current Issue Owner: @fedirjh

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Workflow - No bottom margin after enabling approval and delay submission

What is the root cause of that problem?

The default value of includeSafeAreaPaddingBottom is false in WorkspacePageWithSections

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 113 in d46c4cc

includeSafeAreaPaddingBottom = false,

And in WorkspaceWorkflowsPage, we're using the above default value for includeSafeAreaPaddingBottom

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Lines 338 to 348 in d46c4cc

	<WorkspacePageWithSections
	headerText={translate('workspace.common.workflows')}
	icon={Illustrations.Workflows}
	route={route}
	guidesCallTaskID={CONST.GUIDES_CALL_TASK_IDS.WORKSPACE_WORKFLOWS}
	shouldShowOfflineIndicatorInWideScreen
	shouldShowNotFoundPage={!isPaidGroupPolicy || !isPolicyAdmin}
	isLoading={isLoading}
	shouldShowLoading={isLoading}
	shouldUseScrollView
	>

Causing bottom of the WorkspaceWorkflowsPage is displayed behind navigation buttons of Android device

What changes do you think we should make in order to solve the problem?

We can pass includeSafeAreaPaddingBottom prop here to ensure it includes padding bottom with navigation buttons

Result:

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A, it's a UI issue

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[RachCHopkins]

Very easy to repro this one!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021885123690732497773

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[shubham1206agra]

This was reported a long time back.

cc @mountiny since this is a dupe.

[shubham1206agra]

@RachCHopkins Thread for context https://expensify.slack.com/archives/C049HHMV9SM/p1736360325497079?thread_ts=1736238279.772929&cid=C049HHMV9SM