[Due for payment 2025-02-18] [$250] Workspace - No animation in LHN when enabling Per diem

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.93-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+9056910@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Control workspace settings > More features.
3. Enable Tags.
4. Note that Tags appear in LHN with animation.
5. Enable Per diem.

Expected Result:

Per diem will animate in LHN.

Actual Result:

Per diem does not animate in LHN.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6729439_1738318660456.20250131_181548.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021886940440312442170
• Upwork Job ID: 1886940440312442170
• Last Price Increase: 2025-02-05
• Automatic offers:
• ishpaul777 | Reviewer | 106012789
• twilight2294 | Contributor | 106012790

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No animation in LHN when enabling Per diem

What is the root cause of that problem?

We do not highight the per diem option:

App/src/pages/workspace/WorkspaceInitialPage.tsx

Lines 239 to 244 in 4459f86

	if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_PER_DIEM_RATES_ENABLED]) {
	protectedMenuItems.push({
	translationKey: 'common.perDiem',
	icon: CalendarSolid,
	action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_PER_DIEM.getRoute(policyID)))),
	routeName: SCREENS.WORKSPACE.PER_DIEM,

This causes the animation to happen

What changes do you think we should make in order to solve the problem?

We need to add highlight for the per diem feature:

if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_PER_DIEM_RATES_ENABLED]) {
            protectedMenuItems.push({
                translationKey: 'common.perDiem',
                highlighted: highlightedFeature === CONST.POLICY.MORE_FEATURES.ARE_PER_DIEM_RATES_ENABLED,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A UI bug

What alternative solutions did you explore? (Optional)

[melvin-bot]

@kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[twilight2294]

@kadiealexander can you please make this external ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021886940440312442170

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)