[Due for payment 2025-02-19] [$250] Incorrect System Message Displayed When Deleting a Report

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): expense

Action Performed:

1. Create a report and submit it to a test workspace.
2. Delete the report.
3. Observe the system message displayed.

Expected Result:

The message should clearly indicate what happened, such as:
"Moved expense from expense report to your personal space."

Actual Result:

The message displayed: "Moved expense from self DM to chat with"
"Self DM" is not a recognized product feature

The screenshot for the issue is in OP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021887252495070927393
• Upwork Job ID: 1887252495070927393
• Last Price Increase: 2025-02-05
• Automatic offers:
• paultsimura | Reviewer | 106012766
• linhvovan29546 | Contributor | 106012768

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[dominictb]

I can reproduce:

1. Create an expense in self DM
2. Press Share it with my accountant
3. Complete the share flow to any workspace
4. Open the expense just moved from self DM to workspace chat
5. Verify message says "Moved expense from self DM to chat with"

@kadiealexander I can take this over.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The message displayed: "Moved expense from self DM to chat with"
"Self DM" is not a recognized product feature

What is the root cause of that problem?

This is a copy update

What changes do you think we should make in order to solve the problem?

Modify these self DM here to personal space or something:

App/src/languages/en.ts

Lines 998 to 999 in bfb97c5

	movedFromSelfDM: ({workspaceName, reportName}: MovedFromSelfDMParams) => `moved expense from self DM to ${workspaceName ?? `chat with ${reportName}`}`,
	movedToSelfDM: 'moved expense to self DM',

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[hoangzinh]

@dominictb it seems you missed "delete report" step.

[linhvovan29546]

@MarioExpensify @paultsimura The message 'moved expense to self DM' came from my PR. Should we follow up on this?

[paultsimura]

Hi @quinthar, the "self DM" copy originally comes from "share expense" flow. It was approved here: https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1733390159603739?thread_ts=1729611433.691999&channel=C01GTK53T8Q&message_ts=1733390159.603739

If "self DM" is incorrect, could you please provide valid copies for both scenarios?

We can update it with @linhvovan29546 as a follow up.