[Due for payment 2025-04-08] [$250] [Offline] List - On disabling all list values, expense page shows dropdown selected when turn online.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.0.99-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Workspace Settings

Action Performed:

1. Launch app
2. Go to workspace settings - more features - enable report fields
3. Add field and create a list type with 2 list values but on confirmation page go offline and save it
4. Open list created and disable all list values
5. Go to workspace chat
6. Create a expense
7. Open the expense and go online
8. Note the list field on told and open it

Expected Result:

On disabling all list values, expense page shows must not shown dropdown selected when turn online.

Actual Result:

On disabling all list values, expense page shows dropdown selected when turn online.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6745788_1739803118819.Screenrecorder-2025-02-17-19-53-24-932_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894547162954323421
• Upwork Job ID: 1894547162954323421
• Last Price Increase: 2025-03-05
• Automatic offers:
• daledah | Contributor | 106400942

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @isabelastisser / @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-19 04:00:53 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• On disabling all list values, expense page shows dropdown selected when turn online.

What is the root cause of that problem?

• When creating a new field, we set value to dropdown optimistically if the field type is dropdown:

App/src/libs/actions/Policy/ReportField.ts

Line 187 in bf68759

value: type === CONST.REPORT_FIELD_TYPES.LIST ? CONST.REPORT_FIELD_TYPES.LIST : null,

• Then when disabling any option in dropdown report field, we clone the previous field list data which contains value: 'dropdown' key - value and send it to BE:

App/src/libs/actions/Policy/ReportField.ts

Line 388 in bf68759

const updatedReportField = cloneDeep(reportField);

lead to in BE side, we stored the report field which has value: 'dropdown'.

• After step 7, we merged the field list in report and policy:

App/src/libs/ReportUtils.ts

Line 3377 in bf68759

const mergedFieldIds = Array.from(new Set([...policyReportFields.map(({fieldID}) => fieldID), ...reportFields.map(({fieldID}) => fieldID)]));

so finally, the dropdown field has dropdown as the value. That value is displayed as mentioned in the bug.

What changes do you think we should make in order to solve the problem?

• We should remove this line:

App/src/libs/actions/Policy/ReportField.ts

Line 187 in bf68759

value: type === CONST.REPORT_FIELD_TYPES.LIST ? CONST.REPORT_FIELD_TYPES.LIST : null,

or we can remove the value key when cloning the report field:

App/src/libs/actions/Policy/ReportField.ts

Line 388 in bf68759

const updatedReportField = cloneDeep(reportField);

    const updatedReportField = cloneDeep({...reportField, value: null});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• None

What alternative solutions did you explore? (Optional)

Besides the main solution, there is a few additional improvements:

• When it is a dropdown field and all the options are disabled, we should disable the field row:

App/src/components/ReportActionItem/MoneyReportView.tsx

Line 155 in b504588

disabled={isFieldDisabled}

disabled={isFieldDisabled || hasEnableOption}

const hasEnableOption = reportField.type !== 'dropdown' || reportField.disabledOptions.some((o) => !o);

• We can also hide right icon and set interactive to false if hasEnableOption is false:

App/src/components/ReportActionItem/MoneyReportView.tsx

Line 154 in b504588

shouldShowRightIcon

• We can hide the field row if there is no available option and the fieldValue is empty:

                                if (!hasEnableOption && !fieldValue) {
                                    return null;
                                }

[mallenexpensify]

@daledah , I'm assuming you're able to reproduce, is that correct?
I'll get to soon (likely next week), not the highest value issue.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[parasharrajat]

I can reproduce this with the steps mentioned in the OP.

19.02.2025_13.19.12_REC.mp4

[melvin-bot]

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

[parasharrajat]

@mallenexpensify Can you please assign me as C+ as I was able to reproduce this #56949 (comment)? Then I can look further reviewing the proposals to solve this issue.