[Due for payment 2025-04-14] [$250] Reports - "Nothing to show" shown on chats, when opening a message and returning.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.99-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Email or phone of affected tester (no customers): ibellicotest+256@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Other

Action Performed:

1. Open the Expensify app.
2. Log in with an account with a large amount of chats and messages.
3. Tap on "Reports"
4. Tap on the dropdown menu and select "Chats"
5. Scroll down to the bottom to load all the messages.
6. Scroll up a bit and open any message.
7. Return using device back button.
8. Try to keep scrolling through chats section.
9. Check the app´s behaviour with this action.

Expected Result:

The user should be able to keep scrolling through the messages on chats section after returning from any opened message.

Actual Result:

"Nothing to show" is displayed on chats section, after the user scrolls to the bottom of the section, opens any message and returns using device back button. User has to return to inbox and reopen "Chats" to see the messages list again.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6746011_1739817191453.Nothing.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021891598421702594676
• Upwork Job ID: 1891598421702594676
• Last Price Increase: 2025-03-10

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021891598421702594676

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[linhvovan29546]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-18 12:14:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - "Nothing to show" shown on chats, when opening a message and returning

What is the root cause of that problem?

We display the "Nothing to show" message based on the shouldShowEmptyState condition. In this case, shouldShowEmptyState is true, which causes "Nothing to show" to be displayed.

App/src/components/Search/index.tsx

Lines 380 to 389 in 1eb00b0

	if (shouldShowEmptyState) {
	return (
	<View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
	<EmptySearchView
	type={type}
	hasResults={searchResults.search.hasResults}
	/>
	</View>
	);
	}

What causes shouldShowEmptyState to be true?

When scrolling to the end of the list, we handle loading more items using the fetchMoreResults function, which increases the offset. However, in this case, while the API is still fetching, fetchMoreResults continues to be triggered, causing the offset to keep increasing. This happens because shouldShowLoadingMoreItems is false (since the offer count is 0). When the offset becomes larger than the search results, the API returns an empty response, leading to shouldShowEmptyState being true.

App/src/components/Search/index.tsx

Lines 449 to 454 in 1eb00b0

	const fetchMoreResults = () => {
	if (!searchResults?.search?.hasMoreResults || shouldShowLoadingState || shouldShowLoadingMoreItems) {
	return;
	}
	setOffset(offset + CONST.SEARCH.RESULTS_PAGE_SIZE);
	};

NOTE: this issue does not relate step 'opening any message'

What changes do you think we should make in order to solve the problem?

We should update the condition for shouldShowLoadingMoreItems to prevent excessive triggering while the API is still fetching data.

App/src/components/Search/index.tsx

Line 256 in 1eb00b0

const shouldShowLoadingMoreItems = !shouldShowLoadingState && searchResults?.search?.isLoading && searchResults?.search?.offset > 0;

    const shouldShowLoadingMoreItems = !shouldShowLoadingState && searchResults?.search?.isLoading
// Or check if searchResults?.search?.offset >= 0
   const shouldShowLoadingMoreItems = !shouldShowLoadingState && searchResults?.search?.isLoading && searchResults?.search?.offset >= 0; 

Since we updated the shouldShowLoadingMoreItems condition, the SearchRowSkeleton footer now displays when the offset is 0. Therefore, we need to update the listFooterContent condition accordingly.

App/src/components/Search/index.tsx

Lines 536 to 543 in 1eb00b0

	listFooterContent={
	shouldShowLoadingMoreItems ? (
	<SearchRowSkeleton
	shouldAnimate
	fixedNumItems={5}
	/>
	) : undefined
	}

            listFooterContent={
                shouldShowLoadingMoreItems && searchResults?.search?.hasMoreResults ? (
                    <SearchRowSkeleton
                        shouldAnimate
                        fixedNumItems={5}
                    />
                ) : undefined
            }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A, UI bug

What alternative solutions did you explore? (Optional)

1. We can update fetchMoreResults to
   https://github.com/Expensify/App/blob/1eb00b066c1da509a1ad5afe19aa4e3c75733b7d/src/components/Search/index.tsx#L449C11-L454

    const fetchMoreResults = () => {
        if (!searchResults?.search?.hasMoreResults || shouldShowLoadingState || shouldShowLoadingMoreItems || searchResults?.search?.isLoading) {
            return;
        }
        setOffset(offset + CONST.SEARCH.RESULTS_PAGE_SIZE);
    };

2. We can update shouldShowLoadingMoreItems to check the searchResults?.search?.offset >=0

[hungvu193]

@linhvovan29546 I don't think I can reproduce it. My account has ~500 reports but couldn't find a way to reproduce. Do you have any trick or tip to reproduce this issue? Thanks

[linhvovan29546]

My account has 100 reports, so I can easily reproduce the issue by continuously scrolling down
Step:

1. Open the Reports tab.
2. Scroll down continuously (observe the offset value until it exceeds my report list, then stop scrolling).
3. The "Nothing to show" message appears.

[hungvu193]

My account has 100 reports, so I can easily reproduce the issue by continuously scrolling down Step:

1. Open the Reports tab.
2. Scroll down continuously (observe the offset value until it exceeds my report list, then stop scrolling).
3. The "Nothing to show" message appears.

Thanks. I can now reproduce but couldn't reproduce it consistently.

Will review the proposal later today.

[linhvovan29546]

Updated proposal #56969 (comment)
Add alternative solutions