Skip to content

[NO PAYMENT REQUIRED][Due for payment 2025-02-26] [Critical] Prevent users from accepting terms by domain in addition to personal betas #56972

@stitesExpensify

Description

@stitesExpensify

Problem

Some of our largest customers (like blackberry) don't want any mention of travel for their employees. This is not something we would normally cater to, but for very large customers we make exceptions.

Solution

  1. Hide the travel buttons for all users who are in the preventSpotnanaTravel beta
  2. If the user does manage to see the button (because their email is a different domain) make sure to block the actual provisioning of travel if the domain account has preventSpotnanaTravel

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation (hyperlinked to channel name):

Action Performed:

  1. Add a user to the preventSpotnanaTravel beta
  2. Log into newdot
  3. Click the FAB

Expected Result:

  1. You do not see the travel button

Actual Result:

  1. You see the travel button

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @jliexpensify

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions