[Due for payment 2025-03-21] [$250] Reports - "View" button is incorrect in Done tab

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

Precondition:

• Go to Workspace settings > Workflows, make sure only "Delayed submissions" is enabled.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two expenses to the workspace chat.
4. Go to Reports.
5. Go to Expense Reports.
6. Go to Drafts.
7. Note that each individual expense has a "View" link which opens the individual expense thread when clicked.
8. Click Submit.
9. Go to Done.
10. Click View button.

Expected Result:

The View button should be blue and it should open the individual expense thread in Done thread.

Actual Result:

The View button is not blue and it does not open the individual expense thread in Done thread.
It opens the expense report instead.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6748636_1740024920613.20250220_121052.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021893018885403819305
• Upwork Job ID: 1893018885403819305
• Last Price Increase: 2025-02-21
• Automatic offers:
• nkdengineer | Contributor | 106364125

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-20 06:52:12 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - "View" button is incorrect in Done tab

What is the root cause of that problem?

With actions is Done, we will show Badge here.

App/src/components/SelectionList/Search/ActionCell.tsx

Line 54 in bf23769

if ((parentAction !== CONST.SEARCH.ACTION_TYPES.PAID && action === CONST.SEARCH.ACTION_TYPES.PAID) || action === CONST.SEARCH.ACTION_TYPES.DONE) {

What changes do you think we should make in order to solve the problem?

1. we should add a condition to only show Badge when it is not isChildListItem

    if ((parentAction !== CONST.SEARCH.ACTION_TYPES.PAID && action === CONST.SEARCH.ACTION_TYPES.PAID) || (action === CONST.SEARCH.ACTION_TYPES.DONE && !isChildListItem)) {

App/src/components/SelectionList/Search/ActionCell.tsx

Line 54 in bf23769

if ((parentAction !== CONST.SEARCH.ACTION_TYPES.PAID && action === CONST.SEARCH.ACTION_TYPES.PAID) || action === CONST.SEARCH.ACTION_TYPES.DONE) {

2. instead we will show with button here

App/src/components/SelectionList/Search/ActionCell.tsx

Lines 81 to 93 in bf23769

	<Button
	text={text}
	onPress={goToItem}
	small
	style={[styles.w100]}
	innerStyles={buttonInnerStyles}
	link={isChildListItem}
	shouldUseDefaultHover={!isChildListItem}
	icon={!isChildListItem && action === CONST.SEARCH.ACTION_TYPES.REVIEW ? Expensicons.DotIndicator : undefined}
	iconFill={theme.danger}
	iconHoverFill={theme.dangerHover}
	isNested
	/>

Note: We can do the same with similar cases and minor styles can be discussed in PR phase

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021893018885403819305

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[ntdiary]

Under review, there are two points to figure out:

1. Why the action is "done" instead of "view".
2. Ensure that the solution does not affect function in other scenarios

[ntdiary]

OK, I think it's fine to move forward with @nkdengineer's proposal, maybe we can add the desired sub-condition to shouldUseViewAction, and then move the view button and its condition above the badge button. BTW, there is actually another approach, which is to have getAction return the correct action.

App/src/libs/SearchUIUtils.ts

Lines 343 to 345 in d97f1b4

	if (isClosedReport(report)) {
	return CONST.SEARCH.ACTION_TYPES.DONE;
	}

🎀 👀 🎀 C+ reviewed