[Due for payment 2025-03-13] [$250] Saved search - Missing bookmark icon for saved searches

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Search

Action Performed:

Precondition:

• There is a saved search.

1. Launch ND or hybrid app.
2. Go to Reports.
3. Tap Bookmark icon.

Expected Result:

There should be a bookmark icon next to the saved search (previous behavior).

Actual Result:

There is no bookmark icon next to the saved search.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021893117018435599657
• Upwork Job ID: 1893117018435599657
• Last Price Increase: 2025-02-22
• Automatic offers:
• nkdengineer | Contributor | 106256455

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no bookmark icon next to the saved search.

What is the root cause of that problem?

We are not adding icon when creating Saved Search Menu Item

App/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx

Lines 95 to 112 in bf23769

	return {
	...baseMenuItem,
	onSelected: baseMenuItem.onPress,
	rightComponent: (
	<ThreeDotsMenu
	menuItems={getOverflowMenu(baseMenuItem.title ?? '', Number(baseMenuItem.hash ?? ''), item.query ?? '')}
	anchorPosition={{horizontal: 0, vertical: 380}}
	anchorAlignment={{
	horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
	vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,
	}}
	disabled={item.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE}
	/>
	),
	styles: [styles.textSupporting],
	isSelected: false,
	shouldCallAfterModalHide: true,
	};

What changes do you think we should make in order to solve the problem?

We should add saved icon when creating save search menu item.

                ...
                isSelected: false,
                shouldCallAfterModalHide: true,
                icon: Expensicons.Bookmark,

App/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx

Lines 95 to 112 in bf23769

	return {
	...baseMenuItem,
	onSelected: baseMenuItem.onPress,
	rightComponent: (
	<ThreeDotsMenu
	menuItems={getOverflowMenu(baseMenuItem.title ?? '', Number(baseMenuItem.hash ?? ''), item.query ?? '')}
	anchorPosition={{horizontal: 0, vertical: 380}}
	anchorAlignment={{
	horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
	vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,
	}}
	disabled={item.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE}
	/>
	),
	styles: [styles.textSupporting],
	isSelected: false,
	shouldCallAfterModalHide: true,
	};

Note: We can restyle the icon so that it aligns with the icons above.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021893117018435599657

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[jayeshmangwani]

This is a straightforward bug— the bookmark icon is missing. Let's go with @nkdengineer's Proposal.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.