[Due for payment 2025-03-13] [$250] Track tax - RHP opens tax settings instead of distance rate after selecting the same tax rate

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.3-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Distance rates and tax features are enabled.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Distance rates.
3. Click Settings.
4. Enable Track tax.
5. Close the RHP.
6. Open any distance rate.
7. Click Tax rate.
8. Select a tax rate.
9. Click Tax rate.
10. Click on the already selected tax rate.

Expected Result:

RHP will return to distance rate page.

Actual Result:

RHP opens tax settings page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6749810_1740123564296.20250221_152838.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021892975947202280745
• Upwork Job ID: 1892975947202280745
• Last Price Increase: 2025-02-21
• Automatic offers:
• daledah | Contributor | 106307625

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-21 08:38:35 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

RHP opens tax settings page.

What is the root cause of that problem?

When we click the item again we call onDismiss function

App/src/components/TaxPicker.tsx

Lines 101 to 106 in 9d8eef2

	const handleSelectRow = useCallback(
	(newSelectedOption: TaxOptionsListUtils.TaxRatesOption) => {
	if (selectedOptionKey === newSelectedOption.keyForList) {
	onDismiss();
	return;
	}

We should navigate to WORKSPACE_TAXES_SETTINGS route

App/src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx

Lines 53 to 55 in 9d8eef2

	const dismiss = () => {
	Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
	};

What changes do you think we should make in order to solve the problem?

We are navigating to WORKSPACE_DISTANCE_RATE_DETAILS route when dismissing

    const dismiss = () => {
        Navigation.goBack(ROUTES.WORKSPACE_DISTANCE_RATE_DETAILS.getRoute(policyID, rateID));
    };

App/src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx

Lines 53 to 55 in 9d8eef2

	const dismiss = () => {
	Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
	};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

RHP opens tax settings instead of distance rate after selecting the same tax rate

What is the root cause of that problem?


The implementation of PolicyDistanceRateTaxRateEditPage is totally wrong here. 

The current bug happens because when we select the same option we call dismiss function:



App/src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx

Lines 53 to 55 in 9d8eef2

	const dismiss = () => {
	Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
	};

This leads us to the WORKSPACE_TAXES_SETTINGS page.


This is the RCA, now there is not need to call the dismiss function here, we already handle the logic to navigate back in the onTaxRateChange function:


App/src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx

Lines 33 to 37 in 9d8eef2

	const onTaxRateChange = (newTaxRate: TaxOptionsListUtils.TaxRatesOption) => {
	if (taxRateExternalID === newTaxRate.code) {
	Navigation.goBack();
	return;
	}


So the use of dismiss was introduced in 


• fix: [Track tax] Disabled tax rate can be selected. #44046

But the implementation was not rightly done leading to this bug, that PR added the filter logic correctly but pretty badly affected the navigation logic.

What changes do you think we should make in order to solve the problem?

1. Remove the use of OnDismiss from the parent TaxPicker, ie. remove the handleSelectRow function:

App/src/components/TaxPicker.tsx

Lines 101 to 110 in bf50378

	const handleSelectRow = useCallback(
	(newSelectedOption: TaxOptionsListUtils.TaxRatesOption) => {
	if (selectedOptionKey === newSelectedOption.keyForList) {
	onDismiss();
	return;
	}
	onSubmit(newSelectedOption);
	},
	[onSubmit, onDismiss, selectedOptionKey],
	);

2. Replace the usage of handleSelectRow with onSubmit as that is what is done when we select the row:
   

   App/src/components/TaxPicker.tsx

   Line 119 in bf50378

   onSelectRow={handleSelectRow}

3. Remove onDismiss function in PolicyDistanceRateTaxRateEditPage:
   

   App/src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx

   Lines 53 to 56 in 9d8eef2

   	const dismiss = () => {
   	Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));
   	};

4. The case when we select the same key is already taken care of here:

App/src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx

Lines 33 to 36 in 9d8eef2

	const onTaxRateChange = (newTaxRate: TaxOptionsListUtils.TaxRatesOption) => {
	if (taxRateExternalID === newTaxRate.code) {
	Navigation.goBack();
	return;

So we don't need to introduce any new thing. We also need to update a few places where TaxPicker is used, but this is the clean approach to solve this bug as we do not need OnDismiss and handleSelectRow can directly have the function onSubmit which simplifies logic handling



What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A this is a navigation bug

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021892975947202280745

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[melvin-bot]

@ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!