[Due for payment 2025-04-16] [$250] The global create tooltip does not display when switching between the Settings page and the Inbox page.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.7-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @linhvovan29546
Slack conversation (hyperlinked to channel name): #Convert

Action Performed:

1. Log in to ND with a new account.
2. Complete onboarding.
3. Verify that the global create tooltip is displayed.
4. Navigate to the Settings page.
5. Navigate to the Inbox page.

Expected Result:

The tooltip should display consistently.

Actual Result:

Describe what actually happened

Workaround:

In step 4, the 'Your to-do list' tooltip does not appear.
In step 5, the global create tooltip does not appear.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

414536672-914ad1bf-35a8-40b1-99e3-0ea714455451.mov

Recording.1016.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021895645417530854887
• Upwork Job ID: 1895645417530854887
• Last Price Increase: 2025-03-15
• Automatic offers:
• CyberAndrii | Contributor | 106618173

Issue Owner

Current Issue Owner: @allroundexperts / @dylanexpensify

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[m-natarajan]

@mallenexpensify As per your comment linking the issue #54925

[andriivitiv]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-28 23:17:13 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The global create tooltip does not display when switching between the Settings page and the Inbox page.

What is the root cause of that problem?

Take a look at this code

App/src/components/ProductTrainingContext/index.tsx

Lines 175 to 182 in b353234

	useEffect(() => {
	if (shouldShow) {
	registerTooltip(tooltipName);
	}
	return () => {
	unregisterTooltip(tooltipName);
	};
	}, [tooltipName, registerTooltip, unregisterTooltip, shouldShow]);

Notice that registerTooltip is called only when shouldShow is true. However, unregisterTooltip is not wrapped in the same shouldShow check, so it is called even when it shouldn’t be.

The tooltip is registered when the Inbox page is opened. Nothing changes when the Settings page is opened. The issue occurs when the Settings page closes while navigating back to the Inbox page. At that point unregisterTooltip is called even though the tooltip was not registered on the Settings page, so it shouldn't be unregistered there.

What changes do you think we should make in order to solve the problem?

Wrap the unregisterTooltip(tooltipName); line in an if (shouldShow) check as it is done with registerTooltip

 useEffect(() => {
     if (shouldShow) {
         registerTooltip(tooltipName);
     }
     return () => {
+        if (shouldShow) {
             unregisterTooltip(tooltipName);
+        }
     };
 }, [tooltipName, registerTooltip, unregisterTooltip, shouldShow]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

A test that will first render useProductTrainingContext hook with shouldShow: true. Then shouldShow: false. Then unmount the second useProductTrainingContext and validate that shouldRenderTooltip still returns true.

[mallenexpensify]

Thanks for the proposal @CyberAndrii , I was planning to check with @linhvovan29546 to see if they wanted to work on this issue first, cuz they found and reported it as part of this issue (which is also why I asked to be assigned and haven't added Help Wanted yet).

@linhvovan29546 were you wanting to work on this or should I have a C+ review @CyberAndrii 's proposal?
Thx

[linhvovan29546]

Thx @mallenexpensify please assign another one. I don't have time to look into this deeply, but from my previous debugging, I think @CyberAndrii 's RCA is correct.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021895645417530854887

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)