[$250] [Due for payment 2025-03-24] Move groupBy to the Query Syntax for Improved Access

[289Adam289]

Currently, the user is unable to enter the Expense Report view on the Reports page using the Search Router. The only way for a user to access grouped reports is by navigating to the Reports page and inserting the desired query there.

We can simplify the code and reuse existing logic by moving the groupBy key into the query syntax. This change would allow users to access the Expense Report from any screen.

cc @Kicu @luacmartins

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904651255983113800
• Upwork Job ID: 1904651255983113800
• Last Price Increase: 2025-03-25

Issue Owner

Current Issue Owner: @

[289Adam289]

@luacmartins I've discussed this issue and how we can improve the code base with @Kicu. Could please you assign me?

[luacmartins]

Thanks for creating this one. Assigned you to it.

[289Adam289]

@luacmartins I've moved the group-by to the query syntax. Currently, its behavior is similar to how it works on staging (navigation param) and is similar to how sort-by and sort-order work. This means it is not visible after submitting the query.

The question is: Should the group-by filter function like sort-by and sort-order, which have a visual indication in the current UI and are removed from the query after submitting, or should it work like the category filter, which, when used, is always visible inside the query?

This is how it looks in draft pr:

Screen.Recording.2025-03-05.at.15.32.45.mov

[luacmartins]

@289Adam289 it should work as the category filter. If the value is not the default, it should always be visible

[289Adam289]

In that case, should there be an autocomplete for group-by, and should the value be highlighted? @luacmartins

[luacmartins]

I think for now, yes let's add it to autocomplete and highlight it. We're working on a separate Search v3 design doc that will introduce more possible values for group-by, so it'll make it easier to build on top of that.