[Due for payment 2025-03-21] [$250] Workflows- Extra pages open when returning from approval workflow setup via device gesture

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Workspace Settings

Action Performed:

1. Launch ND or hybrid app.
2. Go to workspace settings > Workflows.
3. Tap Add approval workflow.
4. Select a user > Next.
5. Tap Got it.
6. Tap Approver > Got it.
7. Tap app back button three times.
8. Note that app returns to Workflows page.
9. Repeat Step 3 to 6.
10. Swipe to right three times (iOS gesture).
11. Note that app returns to "No members to display" page instead of workflows settings.
12. Swipe two more times.
13. Note that app only returns to Workflows page after swiping to right five times instead of three times as compared to using app back button.

Expected Result:

In Step 11, app will return to Workflows settings.

Actual Result:

In Step 11, app returns to "No members to display" page instead of workflows settings.
In Step 13, app only returns to Workflows page after swiping to right five times instead of three times as compared to using app back button.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6760575_1741063873480.ScreenRecording_03-04-2025_12-41-47_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897227974697280091
• Upwork Job ID: 1897227974697280091
• Last Price Increase: 2025-03-05

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are extra pages when open the approver page and then press the confirm button from the approval confirm page.

What is the root cause of that problem?

When we press the "Got it" button from the approver page that is accessed from the confirm page, we simply navigate to the confirm page again if it's a create action.

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Lines 182 to 184 in b649380

	if (approvalWorkflow?.action === CONST.APPROVAL_WORKFLOW.ACTION.CREATE) {
	Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_NEW.getRoute(route.params.policyID));
	} else {

So now, we have 2 approver confirm page on the nav stack.

What changes do you think we should make in order to solve the problem?

We only need to navigate to the confirm page if it's an initial creation flow, otherwise, we will use go back action.

if (isInitialCreationFlow) {
    Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_NEW.getRoute(route.params.policyID));
} else {
    goBack();
}

We can handle other page of the approval flow too.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Or if backTo param exists, we can go back using the backTo param.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021897227974697280091

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[c3024]

@bernhardoj 's RCA and suggested fix in his proposal looks good to me!

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.